Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753766AbdCOT52 (ORCPT ); Wed, 15 Mar 2017 15:57:28 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:33755 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752119AbdCOT51 (ORCPT ); Wed, 15 Mar 2017 15:57:27 -0400 MIME-Version: 1.0 X-Originating-IP: [108.49.102.27] In-Reply-To: <20170313163126.GA8117@packer-debian-8-amd64.digitalocean.com> References: <20170313163126.GA8117@packer-debian-8-amd64.digitalocean.com> From: Paul Moore Date: Wed, 15 Mar 2017 15:48:07 -0400 Message-ID: Subject: Re: [PATCH v2] audit: log module name on delete_module To: Jessica Yu Cc: Richard Guy Briggs , linux-kernel@vger.kernel.org, linux-audit@redhat.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1180 Lines: 39 On Mon, Mar 13, 2017 at 12:31 PM, Jessica Yu wrote: > +++ Paul Moore [13/03/17 10:16 -0400]: >> >> On Sat, Mar 11, 2017 at 9:24 PM, Richard Guy Briggs >> wrote: >>> >>> When a sysadmin wishes to monitor module unloading with a syscall rule >>> such as: >>> -a always,exit -F arch=x86_64 -S delete_module -F key=mod-unload >>> the SYSCALL record doesn't tell us what module was requested for >>> unloading. >>> >>> Use the new KERN_MODULE auxiliary record to record it. >>> The SYSCALL record result code will list the return code. >>> >>> See: https://github.com/linux-audit/audit-kernel/issues/37 >>> https://github.com/linux-audit/audit-kernel/issues/7 >>> >>> https://github.com/linux-audit/audit-kernel/wiki/RFE-Module-Load-Record-Format >>> >>> Signed-off-by: Richard Guy Briggs >>> --- >>> kernel/module.c | 2 ++ >>> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> >> Jessica? If there are no objections to this patch on your side I'll >> merge this into the audit/next tree. > > > Looks good to me: > > Acked-by: Jessica Yu Merged, thanks everyone. -- paul moore www.paul-moore.com