Date: Fri, 23 May 2003 13:17:57 +0200
From: Ingo Oeser <ingo.oeser@informatik.tu-chemnitz.de>
To: Michael Hunold <hunold@convergence.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC][2.5] generic_usercopy() function (resend, forgot the patches)
Message-ID: <20030523131757.K626@nightmaster.csn.tu-chemnitz.de>
References: <3ECDEBC5.5030608@convergence.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2i
In-Reply-To: <3ECDEBC5.5030608@convergence.de>; from hunold@convergence.de on Fri, May 23, 2003 at 11:37:09AM +0200
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 962
Lines: 30

Hi Michael,

On Fri, May 23, 2003 at 11:37:09AM +0200, Michael Hunold wrote:
> In order to prevent this code duplication, introducing a
> generic_usercopy() function to lib/ is one possibilty.

I like the idea, because whoever invented the IOCTL generation
macros forgot exactly this function.

This raised the problem, that some IOCTLs have the wrong numbers
due to the author not being able to grok the macros and/or
documentation.

Also many authors have problems evaluating their IOCTLs and get
directions wrong.

So this code helps these issues. 

I just miss variants for the smaller sizes. These should be
handled differently and more easily, 
so better warn about sizes <= sizeof(void *).

Regards

Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/