Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754024AbdCOVpH (ORCPT ); Wed, 15 Mar 2017 17:45:07 -0400 Received: from mail-it0-f54.google.com ([209.85.214.54]:37905 "EHLO mail-it0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753063AbdCOVpF (ORCPT ); Wed, 15 Mar 2017 17:45:05 -0400 MIME-Version: 1.0 In-Reply-To: <88708a0d-7b8a-b1d7-ee66-fd51c6bfe0fe@cogentembedded.com> References: <1489526601-9423-1-git-send-email-tremyfr@gmail.com> <88708a0d-7b8a-b1d7-ee66-fd51c6bfe0fe@cogentembedded.com> From: Philippe Reynes Date: Wed, 15 Mar 2017 22:45:03 +0100 Message-ID: Subject: Re: [PATCH] net: sun: sungem: rix a possible null dereference To: Sergei Shtylyov Cc: davem@davemloft.net, mugunthanvnm@ti.com, jarod@redhat.com, felipe.balbi@linux.intel.com, edumazet@google.com, fw@strlen.de, dan.carpenter@oracle.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 29 Hi Sergei, On 3/15/17, Sergei Shtylyov wrote: > Hello! > > On 3/15/2017 12:23 AM, Philippe Reynes wrote: > >> The function gem_begin_auto_negotiation dereference >> the pointer ep before testing if it's null. This >> patch add a check on ep before dereferencing it. >> >> This issue was added by the patch 92552fdd557: >> "net: sun: sungem: use new api ethtool_{get|set}_link_ksettings". > > There's Fixes: tag for that now, described in > Documentation/process/submitting-patches.rst... Thanks a lot for pointing me this tag. I'm sending a v2 of this patch with this tag. >> Reported-by: Dan Carpenter >> Signed-off-by: Philippe Reynes > [...] > > MBR, Sergei > Thanks, Philippe