Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754102AbdCOWfI (ORCPT ); Wed, 15 Mar 2017 18:35:08 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:55256 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752027AbdCOWet (ORCPT ); Wed, 15 Mar 2017 18:34:49 -0400 Date: Wed, 15 Mar 2017 15:34:44 -0700 (PDT) Message-Id: <20170315.153444.911901357692024194.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, f.fainelli@gmail.com, andrew@lunn.ch, jcobham@questertangent.com Subject: Re: [PATCH net-next v2 0/3] net: dsa: check out-of-range ageing time From: David Miller In-Reply-To: <20170315195350.11059-1-vivien.didelot@savoirfairelinux.com> References: <20170315195350.11059-1-vivien.didelot@savoirfairelinux.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 15 Mar 2017 15:34:45 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 719 Lines: 18 From: Vivien Didelot Date: Wed, 15 Mar 2017 15:53:47 -0400 > The ageing time limits supported by DSA drivers vary depending on the > switch model. If a driver returns -ERANGE for out-of-range values, the > switchdev commit phase will fail with the following stacktrace: ... > This patchset fixes this by adding ageing_time_min and ageing_time_max > fields to the dsa_switch structure, which can optionally be set by a DSA > driver. > > If provided, the DSA core will check for out-of-range values in the > SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME prepare phase and return -ERANGE > accordingly. > > Finally set these limits in the mv88e6xxx driver. Series applied, thanks Vivien.