Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751137AbdCPBMK (ORCPT ); Wed, 15 Mar 2017 21:12:10 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:34188 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751143AbdCPBLa (ORCPT ); Wed, 15 Mar 2017 21:11:30 -0400 Subject: Re: change uprobe_events default ? Was: [PATCH] perf: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS To: Arnaldo Carvalho de Melo , Alexei Starovoitov References: <20170216060050.20866-1-anton@ozlabs.org> <20170316005817.GA6805@ast-mbp.thefacebook.com> <20170316010651.GP12825@kernel.org> Cc: Anton Blanchard , David Miller , Peter Zijlstra , Ingo Molnar , Hemant Kumar , Masami Hiramatsu , Steven Rostedt , Srikar Dronamraju , Wang Nan , Namhyung Kim , Jiri Olsa , alexander.shishkin@linux.intel.com, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org From: David Ahern Message-ID: <698eeeeb-2181-28b3-08dd-018fc5ccd011@gmail.com> Date: Wed, 15 Mar 2017 19:10:56 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170316010651.GP12825@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 915 Lines: 21 On 3/15/17 7:06 PM, Arnaldo Carvalho de Melo wrote: > Added more people to the CC list. > > Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu: >> On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote: >>> We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as >>> well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently >>> use the plurals. > >> this rename made me notice that UPROBE_EVENTS still defaults to 'n'. >> this is key feature that all distros enable, so having default 'n' >> is kinda saying that it's not something that should be turned on >> or used widely. which is obviously not the case. >> imo it's time to change it to 'y'. >> Thoughts? > > Agreed, I also found it strange that it was disabled by default when I > recently did a 'make oldconfig' :-\ Debian stretch, Ubuntu 16.10, Fedora 26 all have it enabled. Perhaps it should default on.