Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751512AbdCPCOb (ORCPT ); Wed, 15 Mar 2017 22:14:31 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41548 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751097AbdCPCOa (ORCPT ); Wed, 15 Mar 2017 22:14:30 -0400 Date: Thu, 16 Mar 2017 11:14:09 +0900 From: Greg Kroah-Hartman To: Okash Khawaja Cc: Samuel Thibault , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Kirk Reiser , speakup@linux-speakup.org, Chris Brannon Subject: Re: [patch 4/4] staging: speakup: move those functions which do outgoing serial comms, into serialio.c Message-ID: <20170316021409.GA26547@kroah.com> References: <20170314134151.603195427@gmail.com> <20170314134523.466213093@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170314134523.466213093@gmail.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 995 Lines: 23 On Tue, Mar 14, 2017 at 01:41:55PM +0000, Okash Khawaja wrote: > This moves spk_synth_immediate and spk_serial_synth_probe functions into > serialio.c. These functions do outgoing serial comms. The move is a step > towards collecting all serial comms in serialio.c. This also renames > spk_synth_immediate to spk_serial_synth_immediate. > > Code inside those functions has not been changed. Along the way, this patch > also fixes a couple of spots which were calling spk_synth_immediate directly, > so that the calls now happen via the spk_syth struct. > > Signed-off-by: Okash Khawaja > Reviewed-by: Samuel Thibault > > Index: linux-4.11-rc2/drivers/staging/speakup/serialio.c This patch doesn't apply to my tree at all. The first 3 applied with some fuzz, so I think you are not working against linux-next. Please rebase your patch against linux-next, or my staging-testing branch, and resend so I can apply it. thanks, greg k-h