Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751475AbdCPCsD (ORCPT ); Wed, 15 Mar 2017 22:48:03 -0400 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:43323 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751431AbdCPCsC (ORCPT ); Wed, 15 Mar 2017 22:48:02 -0400 X-Original-SENDERIP: 156.147.1.125 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 10.177.227.17 X-Original-MAILFROM: namhyung@kernel.org Date: Thu, 16 Mar 2017 11:17:58 +0900 From: Namhyung Kim To: David Ahern Cc: Arnaldo Carvalho de Melo , Alexei Starovoitov , Anton Blanchard , David Miller , Peter Zijlstra , Ingo Molnar , Hemant Kumar , Masami Hiramatsu , Steven Rostedt , Srikar Dronamraju , Wang Nan , Jiri Olsa , alexander.shishkin@linux.intel.com, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@lge.com Subject: Re: change uprobe_events default ? Was: [PATCH] perf: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS Message-ID: <20170316021758.GA1775@sejong> References: <20170216060050.20866-1-anton@ozlabs.org> <20170316005817.GA6805@ast-mbp.thefacebook.com> <20170316010651.GP12825@kernel.org> <698eeeeb-2181-28b3-08dd-018fc5ccd011@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <698eeeeb-2181-28b3-08dd-018fc5ccd011@gmail.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1072 Lines: 29 On Wed, Mar 15, 2017 at 07:10:56PM -0600, David Ahern wrote: > On 3/15/17 7:06 PM, Arnaldo Carvalho de Melo wrote: > > Added more people to the CC list. > > > > Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu: > >> On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote: > >>> We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as > >>> well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently > >>> use the plurals. > > > >> this rename made me notice that UPROBE_EVENTS still defaults to 'n'. > >> this is key feature that all distros enable, so having default 'n' > >> is kinda saying that it's not something that should be turned on > >> or used widely. which is obviously not the case. > >> imo it's time to change it to 'y'. > >> Thoughts? > > > > Agreed, I also found it strange that it was disabled by default when I > > recently did a 'make oldconfig' :-\ > > Debian stretch, Ubuntu 16.10, Fedora 26 all have it enabled. Perhaps it > should default on. +1 Archlinux also has it enabled. Thanks, Namhyung