Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751328AbdCPFgX (ORCPT ); Thu, 16 Mar 2017 01:36:23 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:37875 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750866AbdCPFgV (ORCPT ); Thu, 16 Mar 2017 01:36:21 -0400 Date: Thu, 16 Mar 2017 11:04:29 +0530 From: Srikar Dronamraju To: Arnaldo Carvalho de Melo Cc: Alexei Starovoitov , Anton Blanchard , David Miller , Peter Zijlstra , Ingo Molnar , Hemant Kumar , Masami Hiramatsu , Steven Rostedt , Wang Nan , Namhyung Kim , David Ahern , Jiri Olsa , alexander.shishkin@linux.intel.com, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: change uprobe_events default ? Was: [PATCH] perf: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS Reply-To: Srikar Dronamraju References: <20170216060050.20866-1-anton@ozlabs.org> <20170316005817.GA6805@ast-mbp.thefacebook.com> <20170316010651.GP12825@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20170316010651.GP12825@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable x-cbid: 17031605-0016-0000-0000-000003F66119 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17031605-0017-0000-0000-000028DE627C Message-Id: <20170316053429.GA7001@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-16_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703160044 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 818 Lines: 19 > Added more people to the CC list. > > Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu: > > On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote: > > > We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as > > > well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently > > > use the plurals. > > > this rename made me notice that UPROBE_EVENTS still defaults to 'n'. > > this is key feature that all distros enable, so having default 'n' > > is kinda saying that it's not something that should be turned on > > or used widely. which is obviously not the case. > > imo it's time to change it to 'y'. > > Thoughts? > > Agreed, I also found it strange that it was disabled by default when I > recently did a 'make oldconfig' :-\ Yes, we could make it default on.