Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751097AbdCPFsr (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Mar 2017 01:48:47 -0400
Received: from mail-wr0-f196.google.com ([209.85.128.196]:34894 "EHLO
        mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750866AbdCPFsp (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Mar 2017 01:48:45 -0400
Date: Thu, 16 Mar 2017 06:48:40 +0100
From: Ralph Sennhauser <ralph.sennhauser@gmail.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org,
        devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED
        DEVICE TREE BINDINGS),
        linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH] ARM: dts: mvebu: linksys: enable buffer manager support
Message-ID: <20170316064840.3398bd26@gmail.com>
In-Reply-To: <8760jafiy8.fsf@free-electrons.com>
References: <20170308053312.29243-1-ralph.sennhauser@gmail.com>
        <8760jafiy8.fsf@free-electrons.com>
Organization: none
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1283
Lines: 47

On Wed, 15 Mar 2017 20:17:35 +0100
Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:

> Hi Ralph,
>  
>  On mer., mars 08 2017, Ralph Sennhauser <ralph.sennhauser@gmail.com>
> wrote:
> 
> </snip>
>
> > @@ -88,6 +89,9 @@
> >  			ethernet@70000 {
> >  				status = "okay";
> >  				phy-mode = "rgmii-id";
> > +				buffer-manager = <&bm>;
> > +				bm,pool-long = <1>;
> > +				bm,pool-short = <3>;
> >  				fixed-link {
> >  					speed = <1000>;
> >  					full-duplex;
> > @@ -97,6 +101,9 @@
> >  			ethernet@34000 {
> >  				status = "okay";
> >  				phy-mode = "sgmii";
> > +				buffer-manager = <&bm>;
> > +				bm,pool-long = <0>;
> > +				bm,pool-short = <3>;  
> Any reason to reuse the same pool than the other port?
> 
> As only two ports are used here, then each of them can have use 2 of
> the 4 availables pools. 
> 
> </snip>

Hi Gregory,

It has been quite a while since I have written that patch. Something
written somewhere in the Documentation / commit message which I can't
find anymore gave me the impression that using the same for short
doesn't make a difference. So I went with the pool IDs used for other
similar boards for "consistency".

Will send a v2 shortly using all independent pools using the IDs witch
come most natural in context.

Thanks
Ralph