Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751482AbdCPGnW (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Mar 2017 02:43:22 -0400
Received: from mail-wr0-f195.google.com ([209.85.128.195]:34333 "EHLO
        mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751037AbdCPGnS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Mar 2017 02:43:18 -0400
Date: Thu, 16 Mar 2017 07:40:55 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        Anton Blanchard <anton@ozlabs.org>, David Miller <davem@davemloft.net>,
        Peter Zijlstra <peterz@infradead.org>,
        Hemant Kumar <hemant@linux.vnet.ibm.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
        Wang Nan <wangnan0@huawei.com>, Namhyung Kim <namhyung@kernel.org>,
        David Ahern <dsahern@gmail.com>, Jiri Olsa <jolsa@kernel.org>,
        alexander.shishkin@linux.intel.com, sparclinux@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: change uprobe_events default ? Was: [PATCH] perf: Rename
 CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS
Message-ID: <20170316064055.GA7130@gmail.com>
References: <20170216060050.20866-1-anton@ozlabs.org>
 <20170316005817.GA6805@ast-mbp.thefacebook.com>
 <20170316010651.GP12825@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170316010651.GP12825@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 976
Lines: 27


* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Added more people to the CC list.
> 
> Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu:
> > On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote:
> > > We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as
> > > well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently
> > > use the plurals.
>  
> > this rename made me notice that UPROBE_EVENTS still defaults to 'n'.
> > this is key feature that all distros enable, so having default 'n'
> > is kinda saying that it's not something that should be turned on
> > or used widely. which is obviously not the case.
> > imo it's time to change it to 'y'.
> > Thoughts?
> 
> Agreed, I also found it strange that it was disabled by default when I
> recently did a 'make oldconfig' :-\

Agreed, someone please send a patch (or feel free to include it in the perf 
tooling tree) to switch the default around.

Thanks,

	Ingo