Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751629AbdCPHLW (ORCPT ); Thu, 16 Mar 2017 03:11:22 -0400 Received: from mail-yw0-f174.google.com ([209.85.161.174]:33873 "EHLO mail-yw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751037AbdCPHLU (ORCPT ); Thu, 16 Mar 2017 03:11:20 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170301122602.30025-1-aleksey.makarov@linaro.org> <20170301152304.29635-1-aleksey.makarov@linaro.org> From: "Jayachandran C." Date: Thu, 16 Mar 2017 12:41:18 +0530 Message-ID: Subject: Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console" To: Greg Kroah-Hartman Cc: Aleksey Makarov , linux-serial@vger.kernel.org, Peter Hurley , Jiri Slaby , Russell King , linux-kernel@vger.kernel.org, Robin Murphy , linux-arm-kernel@lists.infradead.org, Sudeep Holla Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 825 Lines: 31 Hi Greg, On Tue, Mar 14, 2017 at 9:44 PM, Sudeep Holla wrote: > > > On 01/03/17 15:23, Aleksey Makarov wrote: >> The original patch makes the condition always true, so it is wrong. >> >> It masks (but not fixes) the bug described in the commit message >> but introduces a regression (no console is selected by SPCR) >> in regular (no 'console=ttyAMA') case. >> >> s/||/&&/ would not fix the problem as the root cause was identified >> incorrectly. >> >> This reverts commit aea9a80ba98a0c9b4de88850260e9fbdcc98360b. >> > > Sorry for that, I will test your patches and respond to that. For this > patch: > > Acked-by: Sudeep Holla > This fixes a regression I see in v4.11-rc2 Tested-by: Jayachandran C I don't see it in the tty/serial tree yet JC.