Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751644AbdCPHm5 (ORCPT ); Thu, 16 Mar 2017 03:42:57 -0400 Received: from mail.kernel.org ([198.145.29.136]:58590 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751093AbdCPHm4 (ORCPT ); Thu, 16 Mar 2017 03:42:56 -0400 Date: Thu, 16 Mar 2017 16:42:42 +0900 From: Masami Hiramatsu To: Arnaldo Carvalho de Melo Cc: Alexei Starovoitov , Anton Blanchard , David Miller , Peter Zijlstra , Ingo Molnar , Hemant Kumar , Masami Hiramatsu , Steven Rostedt , Srikar Dronamraju , Wang Nan , Namhyung Kim , David Ahern , Jiri Olsa , alexander.shishkin@linux.intel.com, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: change uprobe_events default ? Was: [PATCH] perf: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS Message-Id: <20170316164242.71a9ec30fc92dbc43defa1c8@kernel.org> In-Reply-To: <20170316010651.GP12825@kernel.org> References: <20170216060050.20866-1-anton@ozlabs.org> <20170316005817.GA6805@ast-mbp.thefacebook.com> <20170316010651.GP12825@kernel.org> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 981 Lines: 28 On Wed, 15 Mar 2017 22:06:51 -0300 Arnaldo Carvalho de Melo wrote: > Added more people to the CC list. > > Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu: > > On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote: > > > We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as > > > well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently > > > use the plurals. > > > this rename made me notice that UPROBE_EVENTS still defaults to 'n'. > > this is key feature that all distros enable, so having default 'n' > > is kinda saying that it's not something that should be turned on > > or used widely. which is obviously not the case. > > imo it's time to change it to 'y'. > > Thoughts? > > Agreed, I also found it strange that it was disabled by default when I > recently did a 'make oldconfig' :-\ Agreed. Now uprobes is enough stable. (and widely used) Thanks! -- Masami Hiramatsu