Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752004AbdCPKMQ (ORCPT ); Thu, 16 Mar 2017 06:12:16 -0400 Received: from mail-ot0-f194.google.com ([74.125.82.194]:33813 "EHLO mail-ot0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751279AbdCPKMP (ORCPT ); Thu, 16 Mar 2017 06:12:15 -0400 MIME-Version: 1.0 In-Reply-To: <877f3plf57.fsf@concordia.ellerman.id.au> References: <1473501690-11987-1-git-send-email-mpe@ellerman.id.au> <87wpbsuo4x.fsf@concordia.ellerman.id.au> <8760jbump6.fsf@concordia.ellerman.id.au> <877f3plf57.fsf@concordia.ellerman.id.au> From: Arnd Bergmann Date: Thu, 16 Mar 2017 11:05:35 +0100 X-Google-Sender-Auth: Yb7pg2U2fEyQZEHH5mBGRxQFNxc Message-ID: Subject: Re: [PATCH] drivers/pcmcia: NO_IRQ removal for electra_cf.c To: Michael Ellerman Cc: linux-pcmcia@lists.infradead.org, Linux Kernel Mailing List , oss@buserror.net, linuxppc-dev@ozlabs.org, Claudiu Manoil , qiang.zhao@nxp.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 860 Lines: 18 On Thu, Mar 16, 2017 at 10:55 AM, Michael Ellerman wrote: > Arnd Bergmann writes: >> On Wed, Mar 15, 2017 at 6:35 AM, Michael Ellerman wrote: >>> I'll do patches for everything above that's not drivers/soc or >>> include/soc and hopefully we can hear from someone at NXP on the plans >>> for getting the soc parts enabled on arm. >> >> I think the removal of the NO_IRQ references is a requirement for >> getting the drivers working properly on ARM, as the OF platform >> code will use '0' for invalid IRQs. > > OK. So the #define NO_IRQ (-1) in arch/arm/include/asm/irq.h is a red > herring and should be ignored for anything modern? Correct. There are a couple of older (non-DT) platforms that still rely on it, and I also have patches for those, which I intend to revisit at some point. Arnd