Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752041AbdCPKNG (ORCPT ); Thu, 16 Mar 2017 06:13:06 -0400 Received: from mail-ot0-f194.google.com ([74.125.82.194]:34887 "EHLO mail-ot0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751962AbdCPKND (ORCPT ); Thu, 16 Mar 2017 06:13:03 -0400 MIME-Version: 1.0 In-Reply-To: <58C9F6C6.4090700@hisilicon.com> References: <1489372963-9000-1-git-send-email-yuanzhichang@hisilicon.com> <1489372963-9000-6-git-send-email-yuanzhichang@hisilicon.com> <4600523.rWNiWKrYZC@aspire.rjw.lan> <58C9F6C6.4090700@hisilicon.com> From: Arnd Bergmann Date: Thu, 16 Mar 2017 11:13:01 +0100 X-Google-Sender-Auth: KUeYKNbC5ds306iP6wKcS_EFpKk Message-ID: Subject: Re: [PATCH V7 5/7] ACPI: Delay the enumeration on the devices whose dependency has not met To: "zhichang.yuan" Cc: "Rafael J. Wysocki" , Catalin Marinas , Will Deacon , Rob Herring , Frank Rowand , Bjorn Helgaas , Rafael Wysocki , Mark Rutland , Linux ARM , ACPI Devel Maling List , Lorenzo Pieralisi , Benjamin Herrenschmidt , Linux Kernel Mailing List , linuxarm@huawei.com, devicetree@vger.kernel.org, linux-pci , linux-serial@vger.kernel.org, Corey Minyard , liviu.dudau@arm.com, Zou Rongrong , John Garry , Gabriele Paoloni , zhichang.yuan02@gmail.com, kantyzc@163.com, Wei Xu Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1551 Lines: 34 On Thu, Mar 16, 2017 at 3:21 AM, zhichang.yuan wrote: > Hi, Rafael, > > Thanks for your review! > > On 2017/3/14 5:24, Rafael J. Wysocki wrote: >> On Monday, March 13, 2017 10:42:41 AM zhichang.yuan wrote: >>> In commit 40e7fcb1929(ACPI: Add _DEP support to fix battery issue on Asus >>> T100TA), the '_DEP' was supported to solve the dependency of Asus battery. But >>> this patch is specific to Asus battery device. >>> In the real world, there are other devices which need the dependency to play the >>> role on the enumeration order. For example, all the Hip06 LPC >>> periperals(IPMI-BT, uart, etc) must be scanned after the LPC host driver >>> finished the probing. So, it makes sense to add a checking whether the ACPI >>> device meet all the dependencies during its enumeration slot, if not, the >>> enumeration will be delayed till all dependency master finish their work. >>> >>> This patch adds the dependency checking in ACPI enumeration, also the >>> corresponding handling to retrigger the Hip06 LPC peripherals' scanning. >> >> AFAICS, _DEP is generally abused in the wild and cannot be made generic. Sorry. >> > > From the ACPI specification, _DEP is for operation region accesses. > You are right... > > How about we add a ACPI handler for our LPC bus?? Just like amba. > In this way, we also can solve the issue about LPC enumeration order. As far as I can tell, PCI and LPC have exactly the same requirement here, so whatever you end up doing for one should be used for the other as well. Arnd