Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752066AbdCPMGb (ORCPT ); Thu, 16 Mar 2017 08:06:31 -0400 Received: from mail-ua0-f172.google.com ([209.85.217.172]:35248 "EHLO mail-ua0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751821AbdCPMG3 (ORCPT ); Thu, 16 Mar 2017 08:06:29 -0400 MIME-Version: 1.0 In-Reply-To: <1488417536-15110-1-git-send-email-sergio.prado@e-labworks.com> References: <1488417536-15110-1-git-send-email-sergio.prado@e-labworks.com> From: Ulf Hansson Date: Thu, 16 Mar 2017 13:06:27 +0100 Message-ID: Subject: Re: [PATCH v4 0/2] mmc: host: s3cmci: add device tree support To: Sergio Prado Cc: Rob Herring , Mark Rutland , "linux-mmc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Ben Dooks , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1452 Lines: 40 On 2 March 2017 at 02:18, Sergio Prado wrote: > This series adds support for configuring Samsung's S3C24XX MMC/SD/SDIO > controller via device tree. > > Tested on FriendlyARM mini2440, based on s3c2440 SoC. > > Changes since v3 (as suggested by Rob Herring) > - describing properties that wasn't documented and removing unnecessary > comment in the device tree binding > > Changes since v2: > - struct "s3cmci_drv_data" and flag "is2440" renamed > - copying the whole driver data struct instead of only its member so > it will be easier to extend the information in the future > - using mmc_of_parse() to read "cd-gpios" and "wp-gpios" properties > from device tree > > Changes since v1: > - pinctrl description removed from DT binding > - unit and label on DT binding renamed to mmc > > Sergio Prado (2): > dt-bindings: mmc: add DT binding for S3C24XX MMC/SD/SDIO controller > mmc: host: s3cmci: allow probing from device tree > > .../devicetree/bindings/mmc/samsung,s3cmci.txt | 42 +++ > drivers/mmc/host/s3cmci.c | 298 +++++++++++---------- > drivers/mmc/host/s3cmci.h | 3 +- > 3 files changed, 200 insertions(+), 143 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mmc/samsung,s3cmci.txt > > -- > 1.9.1 > Sergio, can you please re-spin and address the comments from Jaehoon, then I am happy to apply this! Kind regards Uffe