Subject: Re: [PATCH v4 0/5] perf report: Show inline stack
To: Milian Wolff <milian.wolff@kdab.com>
References: <1488537785-10684-1-git-send-email-yao.jin@linux.intel.com>
 <148956608.Gr0Z3zOxTt@milian-kdab2>
Cc: acme@kernel.org, jolsa@kernel.org, Linux-kernel@vger.kernel.org,
        ak@linux.intel.com, kan.liang@intel.com
From: "Jin, Yao" <yao.jin@linux.intel.com>
Message-ID: <5e14721e-57af-b009-06d6-9cd27391b9d9@linux.intel.com>
Date: Thu, 16 Mar 2017 21:47:13 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <148956608.Gr0Z3zOxTt@milian-kdab2>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1026
Lines: 27

Hi Wolff,

Thanks so much for your review comments!

I just send out the v5 patch series. The patch series are updated 
according to your comments.

Thanks

Jin Yao

On 3/14/2017 8:59 PM, Milian Wolff wrote:
> On Friday, March 3, 2017 11:43:00 AM CET Jin Yao wrote:
>> v4: Remove the options "--inline-line" and "--inline-name". Just use
>>      a new option "--inline" to print the inline function information.
>>      The policy is if the inline function name can be resolved then
>>      print the name in priority. If the name can't be resolved, then
>>      print the source line number.
> This is still wrong from a usability POV. I may want to see the file/line for
> entry that have a name. And actually, there are afaik no situations where you
> could have a file/line but not a symbol name.
>
> Again, why don't you align this with the other non-inlined frames, and honor
> the grouping setting? Check whether we group by address (then display file/
> line), or by function (then display the function name).
>
> Bye