MIME-Version: 1.0
In-Reply-To: <87shmdjx4u.fsf@concordia.ellerman.id.au>
References: <20170311194702.28754-1-khuey@kylehuey.com> <20170311194702.28754-7-khuey@kylehuey.com>
 <CA+55aFxGYA_MnVnmtqfX+AW3hE-KE9Bvev65urRKCA7BgmRiOA@mail.gmail.com> <87shmdjx4u.fsf@concordia.ellerman.id.au>
From: Kyle Huey <me@kylehuey.com>
Date: Thu, 16 Mar 2017 07:30:42 -0700
Message-ID: <CAP045ArvvVVNOLDzMp=B_1AMsRBb9n2qkChkdB7gaEscTOh4Xg@mail.gmail.com>
Subject: Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        "Robert O'Callahan" <robert@ocallahan.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        "the arch/x86 maintainers" <x86@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Jeff Dike <jdike@addtoit.com>, Richard Weinberger <richard@nod.at>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Shuah Khan <shuah@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Borislav Petkov <bp@suse.de>, Peter Zijlstra <peterz@infradead.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Len Brown <len.brown@intel.com>,
        Dmitry Safonov <dsafonov@virtuozzo.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        David Matlack <dmatlack@google.com>, Nadav Amit <nadav.amit@gmail.com>,
        Andi Kleen <andi@firstfloor.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        uml-devel <user-mode-linux-devel@lists.sourceforge.net>,
        "open list:USER-MODE LINUX (UML)" 
        <user-mode-linux-user@lists.sourceforge.net>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        KVM list <kvm@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 791
Lines: 27

On Thu, Mar 16, 2017 at 4:09 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> Linus Torvalds <torvalds@linux-foundation.org> writes:
>
>> Kyle,
>>  your patch format is really odd.
>>
>> You seem to have *eight* lines of context rather than the regular 3.
>> Is there any reason for that oddity?
>>
>> It basically means that a one-line hunk ends up being 17 lines of
>> unified diff rather than 7.
>
> Presumably he's done:
>
> $ git config diff.context 8
>
>
> Which I also did at one point because I thought it might help for
> reading diffs, but reverted after realising it also affects the diffs
> that are generated by format-patch etc.
>
> cheers

Indeed.  In my case it dates back to my days hacking on Firefox, which
wants 8 lines of context for patches.  I'll remove it.

- Kyle