Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754325AbdCPPWy convert rfc822-to-8bit (ORCPT ); Thu, 16 Mar 2017 11:22:54 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:15871 "EHLO lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752869AbdCPPV6 (ORCPT ); Thu, 16 Mar 2017 11:21:58 -0400 From: Shiju Jose To: James Morse CC: "rjw@rjwysocki.net" , "lenb@kernel.org" , "bp@suse.de" , "mingo@kernel.org" , "prarit@redhat.com" , "tbaicar@codeaurora.org" , "punit.agrawal@arm.com" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "fu.wei@linaro.org" , "Guohanjun (Hanjun Guo)" , Gabriele Paoloni , John Garry , "xuwei (O)" , "Zhengqiang (turing)" Subject: RE: [PATCH 1/1] acpi:apei:handle GSIV and GPIO notification types Thread-Topic: [PATCH 1/1] acpi:apei:handle GSIV and GPIO notification types Thread-Index: AdKb/AVo0bMmHMsdRZmPj8dTkvGRQACZS/eAAAG82tA= Date: Thu, 16 Mar 2017 15:20:44 +0000 Message-ID: <86258A5CC0A3704780874CF6004BA8A62DCBEEE8@lhreml502-mbs> References: <86258A5CC0A3704780874CF6004BA8A62DCB6D39@lhreml502-mbx> <58CAA06D.7010900@arm.com> In-Reply-To: <58CAA06D.7010900@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.203.181.159] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.58CAAD58.02AF,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 49149b103d013840174eda1900090beb Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2362 Lines: 75 Hi James, > -----Original Message----- > From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi- > owner@vger.kernel.org] On Behalf Of James Morse > Sent: 16 March 2017 14:26 > To: Shiju Jose > Cc: rjw@rjwysocki.net; lenb@kernel.org; bp@suse.de; mingo@kernel.org; > prarit@redhat.com; tbaicar@codeaurora.org; punit.agrawal@arm.com; > linux-acpi@vger.kernel.org; linux-kernel@vger.kernel.org; > fu.wei@linaro.org; Guohanjun (Hanjun Guo); Gabriele Paoloni; John Garry; > xuwei (O); Zhengqiang (turing) > Subject: Re: [PATCH 1/1] acpi:apei:handle GSIV and GPIO notification > types > > On 13/03/17 13:16, Shiju Jose wrote: > > System Controller Interrupts are received by ACPI's error device, > > which in turn notifies the GHES code. The same is true of APEI's GSIV > > and GPIO notification types. > > Add support for GSIV and GPIO sharing the SCI > > register/unregister/notifier code.Rename the list and notifier to > show > > this is no longer just SCI, but anything from the Hardware Error > > Device. > > Reviewed-by: James Morse > > > ... what looks like an existing bug: > > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > index > > b192b42..fd39929 100644 > > --- a/drivers/acpi/apei/ghes.c > > +++ b/drivers/acpi/apei/ghes.c > > @@ -1068,10 +1072,12 @@ static int ghes_remove(struct platform_device > *ghes_dev) > > free_irq(ghes->irq, ghes); > > break; > > case ACPI_HEST_NOTIFY_SCI: > > + case ACPI_HEST_NOTIFY_GSIV: > > + case ACPI_HEST_NOTIFY_GPIO: > > mutex_lock(&ghes_list_mutex); > > > list_del_rcu(&ghes->list); > > Suspiciously, there is no synchronize_rcu() between this list_del_rcu() > and the > kfree(ghes) at the bottom of the function. It looks like 81e88fdc432a > lifted it into the NOTIFY_NMI path. I will send a separate fix. Thanks. Got it. > > > > - if (list_empty(&ghes_sci)) > > - unregister_acpi_hed_notifier(&ghes_notifier_sci); > > + if (list_empty(&ghes_hed)) > > + unregister_acpi_hed_notifier(&ghes_notifier_hed); > > mutex_unlock(&ghes_list_mutex); > > break; > > case ACPI_HEST_NOTIFY_NMI: > > > > > Thanks, > > James Thanks, Shiju > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" > in the body of a message to majordomo@vger.kernel.org More majordomo > info at http://vger.kernel.org/majordomo-info.html