Subject: Re: [PATCH v2] ARM: zynq: Add #io-channel-cells to (x)adc node for
 iio-hwmon
To: Moritz Fischer <mdf@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
References: <1489003884-2489-1-git-send-email-mdf@kernel.org>
CC: Michal Simek <michal.simek@xilinx.com>,
        =?UTF-8?Q?S=c3=b6ren_Brinkmann?= <soren.brinkmann@xilinx.com>,
        Julia Cartwright <julia@ni.com>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
From: Michal Simek <michal.simek@xilinx.com>
Message-ID: <e6da3f38-7039-66e5-5b9d-a44ff42aa9c9@xilinx.com>
Date: Thu, 16 Mar 2017 17:16:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <1489003884-2489-1-git-send-email-mdf@kernel.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2017 16:16:23.2212
 (UTC)
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR02MB1390
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1227
Lines: 49

Hi,

On 8.3.2017 21:11, Moritz Fischer wrote:
> Fix
> 
> OF: /iio_hwmon: could not get #io-channel-cells for
> /amba/adc@f8007100
> OF: /iio_hwmon: could not get #io-channel-cells for
> /amba/adc@f8007100
> OF: /iio_hwmon: could not get #io-channel-cells for
> /amba/adc@f8007100
> 
> by adding the #io-channel-cells property.
> 
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
> Cc: Julia Cartwright <julia@ni.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> ---
> 
> Changes from v1:
> - fix messed up commit message
> ---
>  arch/arm/boot/dts/zynq-7000.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index f3ac9bf..98233a8 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -72,6 +72,7 @@
>  			interrupts = <0 7 4>;
>  			interrupt-parent = <&intc>;
>  			clocks = <&clkc 12>;
> +			#io-channel-cells = <1>;
>  		};
>  
>  		can0: can@e0008000 {
> 

I think it will be good to the next step too.
It means also add iio-hwmon node too.

What do you think?

Thanks,
Michal