Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754986AbdCPQ0C (ORCPT ); Thu, 16 Mar 2017 12:26:02 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:32875 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753862AbdCPQ0A (ORCPT ); Thu, 16 Mar 2017 12:26:00 -0400 Subject: Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization To: Jon Masters , Vadim Lomovtsev References: <1485793552-12614-1-git-send-email-Vadim.Lomovtsev@caviumnetworks.com> <20170130211236.GW20550@bhelgaas-glaptop.roam.corp.google.com> <20170131102830.GA13854@localhost.localdomain> <20170131142525.GA9942@bhelgaas-glaptop.roam.corp.google.com> <20170131145720.GA14231@localhost.localdomain> <20170131203109.GA14127@bhelgaas-glaptop.roam.corp.google.com> <20170201125325.GA15805@localhost.localdomain> <20170201151807.GA15793@bhelgaas-glaptop.roam.corp.google.com> <376ae1df-da85-e576-75d6-3ae2ab0f1b41@jonmasters.org> <20170315113323.GA28027@localhost.localdomain> <251db823-591b-483b-9c55-13c911020fd1@jonmasters.org> Cc: David.Daney@cavium.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, stemerkhanov@CAVIUMNETWORKS.onmicrosoft.com, Bjorn Helgaas , tn@semihalf.com, bhelgaas@google.com, linux-arm-kernel@lists.infradead.org From: David Daney Message-ID: <48b93116-cc0f-e59d-8aa3-704052ad6759@gmail.com> Date: Thu, 16 Mar 2017 09:25:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <251db823-591b-483b-9c55-13c911020fd1@jonmasters.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2376 Lines: 61 On 03/16/2017 07:32 AM, Jon Masters wrote: > Hi Vadim, > > Thanks for your followup and attention to this matter. More below. > > On 03/15/2017 07:33 AM, Vadim Lomovtsev wrote: > >>> The upstream Linux kernel contains a quirk matching entry that looks for >>> "THRX". Therefore, you have already agreed (as of at least January) that >>> this is the prefix that you will use in any firmware updates to support >>> the latest upstream Linux kernel. Please register this prefix promptly. >> >> And from what I know for now - we wont going to register this >> since we have already regsitered "CAV" prefix for that. And this was the part >> of our discussion also. >> >> We had a bit long review of proper implementation of legacy firmware support, >> so my apologise on that. >> >> Please take a look at link to the patchset posted by Tomasz. >> https://www.spinics.net/lists/arm-kernel/msg568741.html > > I'll let others comment on the suitability of taking that for upstream. > >>>>> So the FW will be updated accordingly. >>> >>> Indeed. >> >> Yes, it is now contains "CAVxxx" as _HID for device config object. > > Which is different from the version that was merged into upstream. That > should never have happened. It will never happen again. I have spent some > time over the past few days ensuring folks understand that I will not > allow a repeat of this to occur the next time around. We will have > platforms that are bulletproof and supported by upstream with any > errata fixes in a very carefully controlled manner. There will > under no circumstances ever be a situation like this again. We are still evaluating the merits of registering the values that appeared in v4.10, and not changing them. We should know more in a couple of days. > >>> The version Bjorn merged looks for "THRX". This is the version that you will >>> use, and you will promptly register that prefix with UEFI and provide fixes >>> for existing firmware to correctly use the solution that is upstream. >> >> Cavium FW is updated accordingly to use already registered prefix. >> For existent FW legacy support is posted by Tomasz. > > I'm watching this to ensure it's cleaned up properly. > > Jon. > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >