Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755145AbdCPQkm (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Mar 2017 12:40:42 -0400
Received: from mail-it0-f66.google.com ([209.85.214.66]:35966 "EHLO
        mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752357AbdCPQki (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Mar 2017 12:40:38 -0400
MIME-Version: 1.0
In-Reply-To: <e6da3f38-7039-66e5-5b9d-a44ff42aa9c9@xilinx.com>
References: <1489003884-2489-1-git-send-email-mdf@kernel.org> <e6da3f38-7039-66e5-5b9d-a44ff42aa9c9@xilinx.com>
From: Moritz Fischer <moritz.fischer.private@gmail.com>
Date: Thu, 16 Mar 2017 09:39:44 -0700
Message-ID: <CAJYdmeNc48=OOvRiUjqPBJhz9RCbzeaRGu1Tfm=hrvzkJrSsag@mail.gmail.com>
Subject: Re: [PATCH v2] ARM: zynq: Add #io-channel-cells to (x)adc node for iio-hwmon
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        =?UTF-8?Q?S=C3=B6ren_Brinkmann?= <soren.brinkmann@xilinx.com>,
        Julia Cartwright <julia@ni.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Devicetree List <devicetree@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2GGfDli013828
Content-Length: 1623
Lines: 55

On Thu, Mar 16, 2017 at 9:16 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> Hi,
>
> On 8.3.2017 21:11, Moritz Fischer wrote:
>> Fix
>>
>> OF: /iio_hwmon: could not get #io-channel-cells for
>> /amba/adc@f8007100
>> OF: /iio_hwmon: could not get #io-channel-cells for
>> /amba/adc@f8007100
>> OF: /iio_hwmon: could not get #io-channel-cells for
>> /amba/adc@f8007100
>>
>> by adding the #io-channel-cells property.
>>
>> Signed-off-by: Moritz Fischer <mdf@kernel.org>
>> Cc: Michal Simek <michal.simek@xilinx.com>
>> Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
>> Cc: Julia Cartwright <julia@ni.com>
>> Cc: linux-kernel@vger.kernel.org
>> Cc: devicetree@vger.kernel.org
>> ---
>>
>> Changes from v1:
>> - fix messed up commit message
>> ---
>>  arch/arm/boot/dts/zynq-7000.dtsi | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
>> index f3ac9bf..98233a8 100644
>> --- a/arch/arm/boot/dts/zynq-7000.dtsi
>> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
>> @@ -72,6 +72,7 @@
>>                       interrupts = <0 7 4>;
>>                       interrupt-parent = <&intc>;
>>                       clocks = <&clkc 12>;
>> +                     #io-channel-cells = <1>;
>>               };
>>
>>               can0: can@e0008000 {
>>
>
> I think it will be good to the next step too.
> It means also add iio-hwmon node too.
>
> What do you think?

I hadn't put it in there since dts is supposed to describe hw,
but obviously putting the actual hwmon in there makes it more useful.

I can resubmit with the hwmon node in there.

Cheers,
Moritz