Date: Sat, 24 May 2003 01:25:20 +0200 (CEST)
From: Martin Diehl <lists@mdiehl.de>
To: "David S. Miller" <davem@redhat.com>
cc: akpm@digeo.com, Greg KH <greg@kroah.com>, <linux-kernel@vger.kernel.org>,
       Jean Tourrilhes <jt@hpl.hp.com>, <shemminger@osdl.org>
Subject: Re: [2.5.69] rtnl-deadlock with usermodehelper and keventd
In-Reply-To: <20030523.024308.94566989.davem@redhat.com>
Message-ID: <Pine.LNX.4.44.0305240115130.11940-100000@notebook.home.mdiehl.de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1177
Lines: 31

On Fri, 23 May 2003, David S. Miller wrote:

>    But nope, unfortunately it's still hanging! I've just tested with 
>    2.5.69-bk15. Running into the same deadlock due to sleeping with rtnl 
>    hold. This time however it seems it's triggered from sysfs side!
> 
> Stephen, you need to do the device class stuff outside of the RTNL
> lock please.
> 
> At least I didn't add this bug :-)
> 
> This should fix it.

Well, back online now pretty late ;-)

Yes, as was already reported I can also confirm from testing the deadlock 
is gone now. Thanks for resolving this issue!

Just a minor question before the thread gets closed: Don't we have the 
same problem in the register path? register_netdevice is running unter 
rtnl and calls netdev_register_sysfs. I've never seen a deadlock there, 
but I'd expect this to sleep for hotplug usermode completion as well.
Maybe this is just what you meant by your comment above ;-)

Martin

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/