Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753159AbdCPTJ0 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Mar 2017 15:09:26 -0400
Received: from mail.kernel.org ([198.145.29.136]:38458 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751954AbdCPTJY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Mar 2017 15:09:24 -0400
Date: Thu, 16 Mar 2017 15:07:52 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: x86@kernel.org, Andy Lutomirski <luto@amacapital.net>,
        Pavel Machek <pavel@ucw.cz>,
        kernel list <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>, Andrew Lutomirski <luto@kernel.org>,
        Borislav Petkov <bp@alien8.de>, Brian Gerst <brgerst@gmail.com>,
        Denys Vlasenko <dvlasenk@redhat.com>, Peter Anvin <hpa@zytor.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] x86: mostly disable '-maccumulate-outgoing-args'
Message-ID: <20170316150752.20c698c4@gandalf.local.home>
In-Reply-To: <20170316190401.bplktmr53r7rlq55@treble>
References: <CALCETrWHdra-Po0rNrHn-cV2G=AM2pWR45rRf4t2RZfQR8Lqjg@mail.gmail.com>
        <20170307182855.262ezbon2pm67qfd@treble>
        <CA+55aFyjEuRLN6PMZZqi6k0rA6=AsTTZeN37eyyJM5ig-mnM4w@mail.gmail.com>
        <20170308173703.2h57rsltma3smbcm@treble>
        <CA+55aFw8ZVHtTDT8jCCtwP=oZFVKnDZVa3bMFdzt6+sGqFNeKw@mail.gmail.com>
        <20170308212959.ctb2ktqkg5l6r2xj@treble>
        <20170316154208.6c3mm6qjus3qtr6w@treble>
        <20170316133201.16b9a73a@gandalf.local.home>
        <20170316183635.wlwavbwsgkyjyjcw@treble>
        <20170316185305.lk4pi3a7b5n6uqjd@treble>
        <20170316190401.bplktmr53r7rlq55@treble>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 520
Lines: 15

On Thu, 16 Mar 2017 14:04:01 -0500
Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> > After some snooping I discovered there's some precedent for doing this
> > in the scripts/gcc-*.sh files.  So maybe I'll add a test there and call
> > it from the Makefile.  
> 
> But now I realize that those other tests are just build tests, whereas
> this one needs to be executed.  That's a no-go for cross compilers.  So
> I think we need to do the version check after all.
> 

Fine, but please add a comment saying such.

-- Steve