Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752788AbdCPTsM (ORCPT ); Thu, 16 Mar 2017 15:48:12 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36516 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752494AbdCPTsK (ORCPT ); Thu, 16 Mar 2017 15:48:10 -0400 Date: Thu, 16 Mar 2017 12:48:08 -0700 From: Andrew Morton To: Joakim Tjernlund Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/2] x86: asm/bitops.h Message-Id: <20170316124808.065242d1018f91fa0c60b875@linux-foundation.org> In-Reply-To: <20170316190709.20364-1-joakim.tjernlund@infinera.com> References: <20170316190709.20364-1-joakim.tjernlund@infinera.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 481 Lines: 13 On Thu, 16 Mar 2017 20:07:08 +0100 Joakim Tjernlund wrote: > Replace void * cast with uintptr_t to do pointer arithmetic's Why? The changelog doesn't describe whats wrong with the current code and gives nobody any reason to apply the patch. > Cc: # v4.9+ And you think it should be backported! That makes it even more important that the changelog contain a full description of the end-user visible impact of the fix.