Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754112AbdCPXuj (ORCPT ); Thu, 16 Mar 2017 19:50:39 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:31903 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752072AbdCPXui (ORCPT ); Thu, 16 Mar 2017 19:50:38 -0400 To: Colin King Cc: Bradley Grove , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [SCSI] esas2r: remove redundant NULL check on buffer From: "Martin K. Petersen" Organization: Oracle Corporation References: <20170315164624.17264-1-colin.king@canonical.com> Date: Thu, 16 Mar 2017 19:50:25 -0400 In-Reply-To: <20170315164624.17264-1-colin.king@canonical.com> (Colin King's message of "Wed, 15 Mar 2017 16:46:24 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 269 Lines: 9 Colin King writes: > buffer is a pointer to the static char array event_buffer and > therefore can never be null, so the check is redundant. Remove it. Applied to 4.12/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering