Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754360AbdCQAkd (ORCPT ); Thu, 16 Mar 2017 20:40:33 -0400 Received: from mail-pg0-f45.google.com ([74.125.83.45]:36426 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752179AbdCQAkc (ORCPT ); Thu, 16 Mar 2017 20:40:32 -0400 Date: Thu, 16 Mar 2017 17:32:08 -0700 From: Brian Norris To: Chris Zhong Cc: linux-rockchip@lists.infradead.org, Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Thierry Reding Subject: Re: [PATCH v2 1/2] dt-bindings: Add INNOLUX P079ZCA panel bindings Message-ID: <20170317003205.GA8180@google.com> References: <1489562353-10313-1-git-send-email-zyw@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1489562353-10313-1-git-send-email-zyw@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1549 Lines: 51 On Wed, Mar 15, 2017 at 03:19:12PM +0800, Chris Zhong wrote: > The Innolux P079ZCA is a 7.85" panel with a 768X1024 resolution and > connected to DSI using four lanes. > > Signed-off-by: Chris Zhong > --- > > Changes in v2: None You added documentation for the 'reg' property :) Looks OK to me. Reviewed-by: Brian Norris > > .../bindings/display/panel/innolux,p079zca.txt | 23 ++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/innolux,p079zca.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/innolux,p079zca.txt b/Documentation/devicetree/bindings/display/panel/innolux,p079zca.txt > new file mode 100644 > index 0000000..5c70a83 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/innolux,p079zca.txt > @@ -0,0 +1,23 @@ > +Innolux P079ZCA 7.85" 768x1024 TFT LCD panel > + > +Required properties: > +- compatible: should be "innolux,p079zca" > +- reg: DSI virtual channel of the peripheral > +- power-supply: phandle of the regulator that provides the supply voltage > +- enable-gpios: panel enable gpio > + > +Optional properties: > +- backlight: phandle of the backlight device attached to the panel > + > +Example: > + > + &mipi_dsi { > + panel { > + compatible = "innolux,p079zca"; > + reg = <0>; > + power-supply = <...>; > + backlight = <&backlight>; > + enable-gpios = <&gpio1 13 GPIO_ACTIVE_HIGH>; > + status = "okay"; > + }; > + }; > -- > 2.6.3