Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754884AbdCQAky (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Mar 2017 20:40:54 -0400
Received: from mga14.intel.com ([192.55.52.115]:49381 "EHLO mga14.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754104AbdCQAkx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Mar 2017 20:40:53 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,174,1486454400"; 
   d="scan'208";a="68210822"
Date: Thu, 16 Mar 2017 17:26:56 -0700
From: Andi Kleen <ak@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <helgaas@kernel.org>, x86@kernel.org,
        Peter Anvin <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [patch 7/7] x86/pci/mmcfg: Switch to ECAM config mode if possible
Message-ID: <20170317002656.GO32070@tassilo.jf.intel.com>
References: <20170316215002.726697858@linutronix.de>
 <20170316215057.452220163@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170316215057.452220163@linutronix.de>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 504
Lines: 15

> +	/*
> +	 * The pointer to root_pci_ops has been handed in to ACPI already
> +	 * and is already set in the busses.
> +	 *
> +	 * Switch the functions over to ECAM for all config space accesses.
> +	 */
> +	pci_root_ops.read = pci_ecam_read;
> +	pci_root_ops.write = pci_ecam_write;
> +	pr_info("PCI: Switch to ECAM configuration mode\n");

That patch is fine, but it's generally called MMCONFIG (don't know
where this ECAM term comes from). So please use MMCONFIG or MCFG everywhere,
not ECAM.

-Andi