Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752918AbdCQDdj (ORCPT ); Thu, 16 Mar 2017 23:33:39 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35742 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752147AbdCQDde (ORCPT ); Thu, 16 Mar 2017 23:33:34 -0400 Date: Thu, 16 Mar 2017 20:32:53 -0700 From: Andrew Morton To: Jerome Glisse Cc: John Hubbard , Balbir Singh , linux-kernel@vger.kernel.org, linux-mm , Naoya Horiguchi , David Nellans , Evgeny Baskakov , Mark Hairgrove , Sherry Cheung , Subhash Gutti Subject: Re: [HMM 07/16] mm/migrate: new memory migration helper for use with device memory v4 Message-Id: <20170316203253.755ab6180affcfa3a7a9a1ba@linux-foundation.org> In-Reply-To: <2057035918.7910419.1489715543920.JavaMail.zimbra@redhat.com> References: <1489680335-6594-1-git-send-email-jglisse@redhat.com> <1489680335-6594-8-git-send-email-jglisse@redhat.com> <20170316160520.d03ac02474cad6d2c8eba9bc@linux-foundation.org> <94e0d115-7deb-c748-3dc2-60d6289e6551@nvidia.com> <2057035918.7910419.1489715543920.JavaMail.zimbra@redhat.com> X-Mailer: Sylpheed 3.4.2 (GTK+ 2.24.28; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 657 Lines: 14 On Thu, 16 Mar 2017 21:52:23 -0400 (EDT) Jerome Glisse wrote: > The original intention was for it to be 64bit only, 32bit is a dying > species and before splitting out hmm_ prefix from this code and moving > it to be generic it was behind a 64bit flag. > > If latter one someone really care about 32bit we can only move to u64 I think that's the best compromise. If someone wants this on 32-bit then they're free to get it working. That "someone" will actually be able to test it, which you clearly won't be doing! However, please do check that the impact of this patchset on 32-bit's `size vmlinux' is minimal. Preferably zero.