Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751150AbdCQFEp (ORCPT <rfc822;w@1wt.eu>);
        Fri, 17 Mar 2017 01:04:45 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:42096 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751119AbdCQFEi (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 17 Mar 2017 01:04:38 -0400
Date: Fri, 17 Mar 2017 14:04:21 +0900
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Aleksey Makarov <amakarov.linux@gmail.com>
Cc: "Jayachandran C." <c.jayachandran@gmail.com>,
        Aleksey Makarov <aleksey.makarov@linaro.org>,
        linux-serial@vger.kernel.org, Peter Hurley <peter@hurleysoftware.com>,
        Jiri Slaby <jslaby@suse.com>, Russell King <linux@armlinux.org.uk>,
        linux-kernel@vger.kernel.org, Robin Murphy <robin.murphy@arm.com>,
        linux-arm-kernel@lists.infradead.org,
        Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching
 pl011 console"
Message-ID: <20170317050421.GA9400@kroah.com>
References: <20170301122602.30025-1-aleksey.makarov@linaro.org>
 <20170301152304.29635-1-aleksey.makarov@linaro.org>
 <d1e067f1-e82f-7692-bcc2-e3549887be63@arm.com>
 <CA+7sy7C6zp3giR+ypFXqbsNY_C3ggUgegS1zEWOAybkRBtCn4w@mail.gmail.com>
 <008d062d-1095-5a65-3a69-33bee1f648d7@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <008d062d-1095-5a65-3a69-33bee1f648d7@gmail.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1318
Lines: 44

On Thu, Mar 16, 2017 at 12:31:53PM +0300, Aleksey Makarov wrote:
> 
> 
> On 03/16/2017 10:11 AM, Jayachandran C. wrote:
> > Hi Greg,
> > 
> > On Tue, Mar 14, 2017 at 9:44 PM, Sudeep Holla <sudeep.holla@arm.com> wrote:
> >>
> >>
> >> On 01/03/17 15:23, Aleksey Makarov wrote:
> >>> The original patch makes the condition always true, so it is wrong.
> >>>
> >>> It masks (but not fixes) the bug described in the commit message
> >>> but introduces a regression (no console is selected by SPCR)
> >>> in regular (no 'console=ttyAMA') case.
> >>>
> >>> s/||/&&/ would not fix the problem as the root cause was identified
> >>> incorrectly.
> >>>
> >>> This reverts commit aea9a80ba98a0c9b4de88850260e9fbdcc98360b.
> >>>
> >>
> >> Sorry for that, I will test your patches and respond to that. For this
> >> patch:
> >>
> >> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
> >>
> > 
> > This fixes a regression I see in v4.11-rc2
> > 
> > Tested-by: Jayachandran C <jnair@caviumnetworks.com>
> > 
> > I don't see it in the tty/serial tree yet
> 
> It's commit 713b93f1b849 from tty-next branch of 
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
> 
> So it looks like it is scheduled for 4.12
> 
> Greg, this is a fix for regression.  Can it be applied to 4.11-rcX?

Yes, will do that now, thanks.

greg k-h