Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751184AbdCQGP2 (ORCPT ); Fri, 17 Mar 2017 02:15:28 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:55622 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbdCQGP1 (ORCPT ); Fri, 17 Mar 2017 02:15:27 -0400 Date: Fri, 17 Mar 2017 07:15:21 +0100 (CET) From: Thomas Gleixner To: Andi Kleen cc: LKML , Bjorn Helgaas , x86@kernel.org, Peter Anvin , Borislav Petkov , Peter Zijlstra , Stephane Eranian Subject: Re: [patch 7/7] x86/pci/mmcfg: Switch to ECAM config mode if possible In-Reply-To: <20170317002656.GO32070@tassilo.jf.intel.com> Message-ID: References: <20170316215002.726697858@linutronix.de> <20170316215057.452220163@linutronix.de> <20170317002656.GO32070@tassilo.jf.intel.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 785 Lines: 26 On Thu, 16 Mar 2017, Andi Kleen wrote: > > + /* > > + * The pointer to root_pci_ops has been handed in to ACPI already > > + * and is already set in the busses. > > + * > > + * Switch the functions over to ECAM for all config space accesses. > > + */ > > + pci_root_ops.read = pci_ecam_read; > > + pci_root_ops.write = pci_ecam_write; > > + pr_info("PCI: Switch to ECAM configuration mode\n"); > > That patch is fine, but it's generally called MMCONFIG (don't know > where this ECAM term comes from). ECAM is the official name for the memory mapped configuration mechanism according to the PCI express specification. > So please use MMCONFIG or MCFG everywhere, not ECAM. While I prefer using names which match specifications, I let Bjorn decide on that one. Thanks, tglx