Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751116AbdCQGc3 (ORCPT ); Fri, 17 Mar 2017 02:32:29 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60988 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750997AbdCQGc0 (ORCPT ); Fri, 17 Mar 2017 02:32:26 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C3D47609FB Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vivek.gautam@codeaurora.org MIME-Version: 1.0 In-Reply-To: <20170130192504.19046-1-shuahkh@osg.samsung.com> References: <20170130192504.19046-1-shuahkh@osg.samsung.com> From: Vivek Gautam Date: Fri, 17 Mar 2017 11:54:34 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] usb: dwc3 dwc3_exynos_probe() change goto labels to meaningful names To: Shuah Khan Cc: Felipe Balbi , Greg KH , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Linux USB Mailing List , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1061 Lines: 33 On Tue, Jan 31, 2017 at 12:55 AM, Shuah Khan wrote: > Change goto labels to meaningful names from a series of errNs. > > Signed-off-by: Shuah Khan > --- > > Rebased to usb-next > > drivers/usb/dwc3/dwc3-exynos.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c > index 1515d45..98f74ff 100644 > --- a/drivers/usb/dwc3/dwc3-exynos.c > +++ b/drivers/usb/dwc3/dwc3-exynos.c > @@ -147,53 +147,53 @@ static int dwc3_exynos_probe(struct platform_device *pdev) > exynos->vdd33 = devm_regulator_get(dev, "vdd33"); > if (IS_ERR(exynos->vdd33)) { > ret = PTR_ERR(exynos->vdd33); > - goto err2; > + goto vdd33_err; While you are changing this in probe, care to change in dwc3_exynos_register_phys() as well ? [snip] Regards Vivek -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project