Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262567AbTEXRu1 (ORCPT ); Sat, 24 May 2003 13:50:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262589AbTEXRu1 (ORCPT ); Sat, 24 May 2003 13:50:27 -0400 Received: from phoenix.infradead.org ([195.224.96.167]:32265 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S262567AbTEXRu0 (ORCPT ); Sat, 24 May 2003 13:50:26 -0400 Date: Sat, 24 May 2003 19:03:29 +0100 (BST) From: James Simmons To: Linus Torvalds cc: Christoph Hellwig , Subject: Re: [PATCH] make vt_ioctl ix86isms explicit In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 23 > > sys_ioperm is only implemented on x86 (i386/x86_64). Make the > > ifdefs in vt_ioctl.c more explicit so the other architectures can > > get rid of their stubs in favour of just using sys_ni_syscall in > > the syscall table. (Personally I still wonder why they added it > > at all but that's another question..) > > They were added because this was how the X server got IO permissions a > million years ago. It comes from some random old UNIX/386 thing, it > predates Linux itself as far as I know. > > I'm fairly certain that X itself no longer uses it at all, but there may > be other programs that still do (unlikely). Your patch looks sane, > although it might be equally sane to just remove the code altogether. I suggest we remove it. It was the old way to access the VGA register ports. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/