Date: Fri, 17 Mar 2017 15:01:52 +0100
From: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
Cc: linux-arm-msm@vger.kernel.org,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        linux-soc@vger.kernel.org, Andy Gross <andy.gross@linaro.org>,
        David Brown <david.brown@linaro.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] soc: qcom: smsm: Handle probe deferral
Message-ID: <20170317140152.wj47b2bw2z3sk6nv@latitude>
References: <20170315114357.14446-1-j.neuschaefer@gmx.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="he64nlwaxuncwzwl"
Content-Disposition: inline
In-Reply-To: <20170315114357.14446-1-j.neuschaefer@gmx.net>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1513
Lines: 41


--he64nlwaxuncwzwl
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 15, 2017 at 12:43:56PM +0100, Jonathan Neusch=C3=A4fer wrote:
[...]
> - TODO: Reading qcom_smsm_probe, I noticed memory leaks in error paths:
>   smsm, smsm->entries, etc. are allocated (with devm_kzalloc), but not
>   freed when the function returns early. This should be addressed at
>   some point (in a separate patch).

This is not actually true (see Documentation/driver-model/devres.txt).
Sorry for the noise.


Jonathan Neusch=C3=A4fer

--he64nlwaxuncwzwl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAABAgAGBQJYy+xJAAoJEAgwRJqO81/bFuAQAIfQKSt+dja6ygZHwM8FMDJy
d3BHKMR+p2kmE1DVWFE/1sFQZI7lr4RwQt6aV9Mo/5aMAYor4MBPtXHquIzB0npY
78yy8i2CXoSZz0kuQaGd6X4I8GxegKww16vBLy/8B00Wuwjk+xBWjxAuk1KCCv7/
u3inX57Kl9ZWorXgriZLzoZ9xutxdqsDkbMLFUZNff6rX67il9P3z3tWskSf5tmf
un7hyw7QnBTOyGsZ1/9i+uq4NA4sEmWcavosyxi1D26rKGdGEI4XMk3C+gQ+lE/8
UellJDHGpbiLaTe+sygLo7+nUemiC+EI08flIiE8fBcOhXHx13pfV0XmmDnIjRAj
gtuI8ULfc1/xIkyjisbYrsaA8Xp426zNGYonsT5AH7PPmOc/Fv2ZEBxo05Z4QhaW
snCRG4G5HHimWMeWucIzSsjuAE+FaglcgA7DODHr0yvRTtXYaHEqjY0KBf54C8X+
YxNTKWkgrbgQOeKxhG5/UIpCyIJ6HXIdu+PZqRqs9u/RjTuFaiBMRAIHcEfUPDU3
u0Xo+GlXo9vHcyRcLkYSp2cghII0W2pLjvhKcHRjiM+yJVzX/6/WkF/mdNgxlhJh
dfhSV+NxG+YW11bETaSmLqEXMCVRD5pMeEp7E4Hj3IMMwdYyU9VcuVR251EpWOGA
7PbdmsGkQ20zLGXkntvQ
=bj0C
-----END PGP SIGNATURE-----

--he64nlwaxuncwzwl--