Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751391AbdCQPOH (ORCPT <rfc822;w@1wt.eu>);
        Fri, 17 Mar 2017 11:14:07 -0400
Received: from mga09.intel.com ([134.134.136.24]:5018 "EHLO mga09.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751037AbdCQPNa (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 17 Mar 2017 11:13:30 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,177,1486454400"; 
   d="asc'?scan'208";a="835880141"
Date: Fri, 17 Mar 2017 23:09:59 +0800
From: "Du, Changbin" <changbin.du@intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: changbin.du@intel.com, peterz@infradead.org, mingo@redhat.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf lock: subcommands should include common options
Message-ID: <20170317150959.GA26124@intel.com>
References: <20170317055342.8284-1-changbin.du@intel.com>
 <20170317140834.GC12825@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="bg08WKrSYDhXBjb5"
Content-Disposition: inline
In-Reply-To: <20170317140834.GC12825@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2662
Lines: 77


--bg08WKrSYDhXBjb5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 17, 2017 at 11:08:34AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Mar 17, 2017 at 01:53:42PM +0800, changbin.du@intel.com escreveu:
> > From: Changbin Du <changbin.du@intel.com>
> >=20
> > When I use -i option for report subcommand, it doesn't accept it.
> > We need add common options using OPT_PARENT macro.
> >=20
> > perf lock report -i lock_perf.data
> >   Error: unknown switch `i'
> >=20
> >   Usage: perf lock report [<options>]
> >=20
> >     -f, --force           don't complain, do it
> >     -k, --key <acquired>  key for sorting ...
> >=20
> > Signed-off-by: Changbin Du <changbin.du@intel.com>
> > ---
> >  tools/perf/builtin-lock.c | 19 +++++++++++--------
> >  1 file changed, 11 insertions(+), 8 deletions(-)
> >=20
> > diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
> > index ce3bfb4..710c551 100644
> > --- a/tools/perf/builtin-lock.c
> > +++ b/tools/perf/builtin-lock.c
> > @@ -947,27 +947,30 @@ static int __cmd_record(int argc, const char **ar=
gv)
> > =20
> >  int cmd_lock(int argc, const char **argv, const char *prefix __maybe_u=
nused)
> >  {
> > +	const struct option lock_options[] =3D {
> > +	OPT_STRING('i', "input", &input_name, "file", "input file name"),
> > +	OPT_INCR('v', "verbose", &verbose, "be more verbose (show symbol addr=
ess, etc)"),
> > +	OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace, "dump raw trace in AS=
CII"),
> > +	OPT_END()
> > +	};
> > +
> >  	const struct option info_options[] =3D {
> >  	OPT_BOOLEAN('t', "threads", &info_threads,
> >  		    "dump thread list in perf.data"),
> >  	OPT_BOOLEAN('m', "map", &info_map,
> >  		    "map of lock instances (address:name table)"),
> >  	OPT_BOOLEAN('f', "force", &force, "don't complain, do it"),
>=20
> Good catch, OPT_PARENT came after 'perf lock', but you forgot 'f', I'm
> adding it and renaming 'lock_options' to 'lock_input_options', ok?
>
I am okay, just go ahead. thanks.

--=20
Thanks,
Changbin Du

--bg08WKrSYDhXBjb5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJYy/xHAAoJEAanuZwLnPNUslIIALNvIYrnXPHXDtpvdNdwyv4u
iDLzK2gtw5nJ32uwqhy72zigE8NEeU/bOXuorvVq/MT9cS1OqgLxuq52UM5ekHhn
KBAqLp0rhhXaLdzQ2Cvzg3PfRha4FI/5Gwoj5Ly3WS/3iyaD63GvswDo6HIRvLs0
E1vPZG1m89pck4vygoOVG4jkvAhhj0K03elEIQ/OGQA+bGgXTzZkxj6FW41aZd4T
xNnjVaH2b4uh0AEgYInalzWhgV0DORz/dAgDAzXT6MipX6xDPiRHu1ikku1ayO+y
TKv4mwHMB5XCzmRlfdWbJXKo8OjPFyDaLByrSDkEvjuoJUc9iX1VqSeyitJ8N/s=
=tEoX
-----END PGP SIGNATURE-----

--bg08WKrSYDhXBjb5--