Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751355AbdCQPZx (ORCPT ); Fri, 17 Mar 2017 11:25:53 -0400 Received: from mail-pg0-f50.google.com ([74.125.83.50]:33745 "EHLO mail-pg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751296AbdCQPZs (ORCPT ); Fri, 17 Mar 2017 11:25:48 -0400 Date: Fri, 17 Mar 2017 23:25:23 +0800 From: Leo Yan To: Suzuki K Poulose Cc: Rob Herring , Mark Rutland , Wei Xu , Catalin Marinas , Will Deacon , Andy Gross , David Brown , Michael Turquette , Stephen Boyd , Mathieu Poirier , Guodong Xu , John Stultz , Greg Kroah-Hartman , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, mike.leach@linaro.org, sudeep.holla@arm.com Subject: Re: [PATCH v4 2/7] coresight: of_get_coresight_platform_data: Add missing of_node_put Message-ID: <20170317152523.GC2020@leoy-linaro> References: <1489762943-25849-1-git-send-email-leo.yan@linaro.org> <1489762943-25849-3-git-send-email-leo.yan@linaro.org> <574d8e6b-cd2d-c1be-6c14-09e8be147e93@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <574d8e6b-cd2d-c1be-6c14-09e8be147e93@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1019 Lines: 29 On Fri, Mar 17, 2017 at 03:09:23PM +0000, Suzuki K Poulose wrote: > On 17/03/17 15:02, Leo Yan wrote: > >From: Suzuki K Poulose > > > >The of_get_coresight_platform_data iterates over the possible CPU nodes > >to find a given cpu phandle. However it does not drop the reference > >to the node pointer returned by the of_get_coresight_platform_data. > > > >[Leo: minor tweaks for of_get_coresight_platform_data] > > > >Cc: Leo Yan > >Cc: Mathieu Poirier > >Signed-off-by: Suzuki K Poulose > > You should add your Signed-off-by here when you send somebody's patch, irrespective > of whether you have modified it or not. > e.g: > > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > [Leo: minor tweaks for of_get_coresight_platform_data] > Signed-off-by: Leo Yan Thanks for pointing out this. Will follow up later. [...] Thanks, Leo Yan