Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751079AbdCQSEW (ORCPT ); Fri, 17 Mar 2017 14:04:22 -0400 Received: from mail.skyhub.de ([5.9.137.197]:41420 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101AbdCQSES (ORCPT ); Fri, 17 Mar 2017 14:04:18 -0400 Date: Fri, 17 Mar 2017 19:03:50 +0100 From: Borislav Petkov To: Alexander Potapenko Cc: Peter Zijlstra , Michael Davidson , Michal Marek , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Herbert Xu , "David S. Miller" , Shaohua Li , Dmitry Vyukov , Matthias Kaehlcke , x86@kernel.org, linux-kbuild@vger.kernel.org, LKML , linux-crypto@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: [PATCH 6/7] md/raid10, LLVM: get rid of variable length array Message-ID: <20170317180350.63jjysejk2i6vkon@pd.tnic> References: <20170317001520.85223-1-md@google.com> <20170317001520.85223-7-md@google.com> <20170317120837.pr74cv3xuj7qpoin@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 664 Lines: 17 On Fri, Mar 17, 2017 at 01:32:00PM +0100, Alexander Potapenko wrote: > > IIUC there's only a handful of VLAIS instances in LLVM code, why not > Sorry, "kernel code", not "LLVM code". > > just drop them for the sake of better code portability? And what happens if someone else adds a variable thing like this somewhere else, builds with gcc, everything's fine and patch gets applied? Or something else llvm can't stomach. Does that mean there'll be the occasional, every-so-often whack-a-mole patchset from someone, fixing the kernel build with llvm yet again? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.