MIME-Version: 1.0
In-Reply-To: <CA+55aFzYxqhLoDcepjt4Z3uLRBNdAg5Ou25Uj9vzZO2RfaVrDQ@mail.gmail.com>
References: <20170317115924.GA82960@inn.lkp.intel.com> <CA+55aFwx5D1hSaW6ac3D=30cY7=2i4cPmGn9zB-1a8ywpau3cw@mail.gmail.com>
 <CA+55aFx2ArTYrdd10A07Y-cD==7yCNE-2kZQcMeAoZKnxFCO2Q@mail.gmail.com> <CA+55aFzYxqhLoDcepjt4Z3uLRBNdAg5Ou25Uj9vzZO2RfaVrDQ@mail.gmail.com>
From: Andy Lutomirski <luto@kernel.org>
Date: Fri, 17 Mar 2017 11:20:51 -0700
Message-ID: <CALCETrUtqOmFjj6ie8vaCuM6SX91BNotA-gwf90bUY9hj_qD1g@mail.gmail.com>
Subject: Re: [x86] 45fc8757d1: BUG:unable_to_handle_kernel
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: kernel test robot <xiaolong.ye@intel.com>,
        Thomas Garnier <thgarnie@google.com>, Ingo Molnar <mingo@kernel.org>,
        Alexander Potapenko <glider@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>,
        Andy Lutomirski <luto@kernel.org>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Borislav Petkov <bp@suse.de>, Chris Wilson <chris@chris-wilson.co.uk>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Jiri Kosina <jikos@kernel.org>, Joerg Roedel <joro@8bytes.org>,
        Jonathan Corbet <corbet@lwn.net>, Josh Poimboeuf <jpoimboe@redhat.com>,
        Juergen Gross <jgross@suse.com>, Kees Cook <keescook@chromium.org>,
        Len Brown <len.brown@intel.com>, Lorenzo Stoakes <lstoakes@gmail.com>,
        "Luis R . Rodriguez" <mcgrof@kernel.org>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        Michal Hocko <mhocko@suse.com>, Paolo Bonzini <pbonzini@redhat.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Pavel Machek <pavel@ucw.cz>, Peter Zijlstra <peterz@infradead.org>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        Rusty Russell <rusty@rustcorp.com.au>,
        Stanislaw Gruszka <sgruszka@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>, zijun_hu <zijun_hu@htc.com>,
        LKML <linux-kernel@vger.kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        tipbuild@zytor.com, LKP <lkp@01.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1446
Lines: 41

On Fri, Mar 17, 2017 at 11:07 AM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Fri, Mar 17, 2017 at 11:00 AM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>> On Fri, Mar 17, 2017 at 10:49 AM, Linus Torvalds
>> <torvalds@linux-foundation.org> wrote:
>>>
>>> The linear address can be used to look up which entry it is. I assume
>>> the GDT starts at ffffffffff577000, and that this is at offset 0x60
>>> from that. Whatever descriptor that would be..
>>
>> Hmm. That should be gdt index 12, aka GDT_ENTRY_TLS_MIN.
>>
>> I guess user space can set almost anything there. Including setting a
>> segment type that isn't accessed, and that the CPU will change on the
>> first actual access.
>>
>> We do have code to verify the limits and types etc iirc, I guess we
>> can make sure to set the accessed bit too.
>
> Hmm. "fill_ldt()" does this:
>
>         desc->type              = (info->read_exec_only ^ 1) << 1;
>         desc->type             |= info->contents << 2;
>
> which always leaves bit #0 of ->type clear. That's the A bit.
>
> Does the problem go away if we just add a
>
>         desc->type             |= 1;
>
> to the end there?

I can easily imagine that breaking WINE or DOSEMU because it'll affect
the LDT, too.

How about this:

https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?h=x86/fixes&id=df8110544c6e899897e1b2ec3ab53d9e4ee40f65

I'll see why selftests didn't catch this, too.