Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751417AbdCQV0a (ORCPT ); Fri, 17 Mar 2017 17:26:30 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34040 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751320AbdCQV01 (ORCPT ); Fri, 17 Mar 2017 17:26:27 -0400 Date: Fri, 17 Mar 2017 14:26:23 -0700 From: Dmitry Torokhov To: Masaki Ota <012nexus@gmail.com> Cc: linux-kernel@paulsd.com, nick.m.fletcher@gmail.com, joseph.salisbury@canonical.com, ben@smart-cactus.org, mhocko@suse.com, pali.rohar@gmail.com, rydberg@bitmath.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, masaki.ota@jp.alps.com Subject: Re: [PATCH 2/2] Fix the issue that V8 Button pad Stick button does not work Message-ID: <20170317212623.GG26166@dtor-ws> References: <20170314013413.7260-1-masaki.ota@jp.alps.com> <20170314013413.7260-2-masaki.ota@jp.alps.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170314013413.7260-2-masaki.ota@jp.alps.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1284 Lines: 38 On Tue, Mar 14, 2017 at 10:34:13AM +0900, Masaki Ota wrote: > From: Masaki Ota > - V8 Button pad Stick Right and Middle button don't work. > - Alps stick devices have physical buttons absolutely, so delete "ALPS_BUTTONPAD" check Flag from Stick button process. > > Signed-off-by: Masaki Ota > > Acked-by: Pali Rohar Reworded commit message, marked for stable and applied, thank you. > --- > drivers/input/mouse/alps.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c > index 253f742..262d105 100644 > --- a/drivers/input/mouse/alps.c > +++ b/drivers/input/mouse/alps.c > @@ -1287,10 +1287,8 @@ static int alps_decode_ss4_v2(struct alps_fields *f, > /* handle buttons */ > if (pkt_id == SS4_PACKET_ID_STICK) { > f->ts_left = !!(SS4_BTN_V2(p) & 0x01); > - if (!(priv->flags & ALPS_BUTTONPAD)) { > - f->ts_right = !!(SS4_BTN_V2(p) & 0x02); > - f->ts_middle = !!(SS4_BTN_V2(p) & 0x04); > - } > + f->ts_right = !!(SS4_BTN_V2(p) & 0x02); > + f->ts_middle = !!(SS4_BTN_V2(p) & 0x04); > } else { > f->left = !!(SS4_BTN_V2(p) & 0x01); > if (!(priv->flags & ALPS_BUTTONPAD)) { > -- > 2.9.3 > -- Dmitry