Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751302AbdCQXv2 (ORCPT ); Fri, 17 Mar 2017 19:51:28 -0400 Received: from mail.kernel.org ([198.145.29.136]:33902 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751087AbdCQXv1 (ORCPT ); Fri, 17 Mar 2017 19:51:27 -0400 Date: Sat, 18 Mar 2017 08:14:55 +0900 From: Masami Hiramatsu To: Ravi Bangoria Cc: mingo@redhat.com, acme@kernel.org, brendan.d.gregg@gmail.com, peterz@infradead.org, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jolsa@kernel.org, ak@linux.intel.com, treeze.taeung@gmail.com, mathieu.poirier@linaro.org, hekuang@huawei.com, sukadev@linux.vnet.ibm.com, ananth@in.ibm.com, naveen.n.rao@linux.vnet.ibm.com, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, hemant@linux.vnet.ibm.com Subject: Re: [PATCH v5 7/7] perf/sdt: List events fetched from uprobe_events Message-Id: <20170318081455.9bb3126b594ae54da3abe5b2@kernel.org> In-Reply-To: <20170314150658.7065-8-ravi.bangoria@linux.vnet.ibm.com> References: <20170314150658.7065-1-ravi.bangoria@linux.vnet.ibm.com> <20170314150658.7065-8-ravi.bangoria@linux.vnet.ibm.com> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1733 Lines: 50 The title of this patch seems not correct. On Tue, 14 Mar 2017 20:36:58 +0530 Ravi Bangoria wrote: > Perf was showing warning if user tries to record sdt event without > creating a probepoint. Now we are allowing direct record on sdt > events, remove this stale warning/hint. > > Signed-off-by: Ravi Bangoria > --- > tools/lib/api/fs/tracing_path.c | 17 ++++------------- > 1 file changed, 4 insertions(+), 13 deletions(-) > > diff --git a/tools/lib/api/fs/tracing_path.c b/tools/lib/api/fs/tracing_path.c > index 3e606b9..fa52e67 100644 > --- a/tools/lib/api/fs/tracing_path.c > +++ b/tools/lib/api/fs/tracing_path.c > @@ -103,19 +103,10 @@ int tracing_path__strerror_open_tp(int err, char *buf, size_t size, > * - jirka > */ > if (debugfs__configured() || tracefs__configured()) { > - /* sdt markers */ > - if (!strncmp(filename, "sdt_", 4)) { > - snprintf(buf, size, > - "Error:\tFile %s/%s not found.\n" > - "Hint:\tSDT event cannot be directly recorded on.\n" > - "\tPlease first use 'perf probe %s:%s' before recording it.\n", > - tracing_events_path, filename, sys, name); > - } else { > - snprintf(buf, size, > - "Error:\tFile %s/%s not found.\n" > - "Hint:\tPerhaps this kernel misses some CONFIG_ setting to enable this feature?.\n", > - tracing_events_path, filename); > - } > + snprintf(buf, size, > + "Error:\tFile %s/%s not found.\n" > + "Hint:\tPerhaps this kernel misses some CONFIG_ setting to enable this feature?.\n", > + tracing_events_path, filename); > break; > } > snprintf(buf, size, "%s", > -- > 2.9.3 > -- Masami Hiramatsu