Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751785AbdCSK5b (ORCPT ); Sun, 19 Mar 2017 06:57:31 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:48486 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751286AbdCSK5Y (ORCPT ); Sun, 19 Mar 2017 06:57:24 -0400 Subject: Re: [PATCH v2 11/17] iio: dac: max5821: Set .of_match_table to OF device ID table To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <20170315044505.20660-1-javier@osg.samsung.com> <20170315044505.20660-12-javier@osg.samsung.com> Cc: linux-iio@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler From: Jonathan Cameron Message-ID: Date: Sun, 19 Mar 2017 10:56:38 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170315044505.20660-12-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 753 Lines: 24 On 15/03/17 04:44, Javier Martinez Canillas wrote: > The driver has a OF device ID table but the struct i2c_driver > .of_match_table field is not set. > > Signed-off-by: Javier Martinez Canillas applied. > --- > > drivers/iio/dac/max5821.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/dac/max5821.c b/drivers/iio/dac/max5821.c > index 86e9e112f554..193fac3059a3 100644 > --- a/drivers/iio/dac/max5821.c > +++ b/drivers/iio/dac/max5821.c > @@ -392,6 +392,7 @@ MODULE_DEVICE_TABLE(of, max5821_of_match); > static struct i2c_driver max5821_driver = { > .driver = { > .name = "max5821", > + .of_match_table = max5821_of_match, > .pm = MAX5821_PM_OPS, > }, > .probe = max5821_probe, >