Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751917AbdCSK5n (ORCPT ); Sun, 19 Mar 2017 06:57:43 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:48502 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751843AbdCSK5j (ORCPT ); Sun, 19 Mar 2017 06:57:39 -0400 Subject: Re: [PATCH v2 13/17] iio: magnetometer: mag3110: Add OF device ID table To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <20170315044505.20660-1-javier@osg.samsung.com> <20170315044505.20660-14-javier@osg.samsung.com> Cc: linux-iio@vger.kernel.org, Hartmut Knaack , Gregor Boirie , Sanchayan Maity , Lars-Peter Clausen , Alison Schofield , Peter Meerwald-Stadler From: Jonathan Cameron Message-ID: <387d82d1-567f-8f79-6299-24457c3fb38f@kernel.org> Date: Sun, 19 Mar 2017 10:57:31 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170315044505.20660-14-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1356 Lines: 38 On 15/03/17 04:45, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the MODALIAS reported will always be of the form i2c:. > > But this could change in the future so the correct approach is to have an > OF device ID table if the devices are registered via OF. > > Signed-off-by: Javier Martinez Canillas Applied. > --- > > drivers/iio/magnetometer/mag3110.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/iio/magnetometer/mag3110.c b/drivers/iio/magnetometer/mag3110.c > index b4f643fb3b1e..dad8d57f7402 100644 > --- a/drivers/iio/magnetometer/mag3110.c > +++ b/drivers/iio/magnetometer/mag3110.c > @@ -441,9 +441,16 @@ static const struct i2c_device_id mag3110_id[] = { > }; > MODULE_DEVICE_TABLE(i2c, mag3110_id); > > +static const struct of_device_id mag3110_of_match[] = { > + { .compatible = "fsl,mag3110" }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, mag3110_of_match); > + > static struct i2c_driver mag3110_driver = { > .driver = { > .name = "mag3110", > + .of_match_table = mag3110_of_match, > .pm = MAG3110_PM_OPS, > }, > .probe = mag3110_probe, >