Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752038AbdCSK6u (ORCPT ); Sun, 19 Mar 2017 06:58:50 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:48530 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752013AbdCSK6r (ORCPT ); Sun, 19 Mar 2017 06:58:47 -0400 Subject: Re: [PATCH v2 16/17] iio: accel: mma7660: Add OF device ID table To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <20170315044505.20660-1-javier@osg.samsung.com> <20170315044505.20660-17-javier@osg.samsung.com> Cc: Martin Klepplinger , linux-iio@vger.kernel.org, Hartmut Knaack , Constantin Musca , Wei Yongjun , Hans de Goede , Lars-Peter Clausen , Peter Meerwald-Stadler From: Jonathan Cameron Message-ID: <7164e9fc-1270-3330-ea6b-408da8ad6927@kernel.org> Date: Sun, 19 Mar 2017 10:58:39 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170315044505.20660-17-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1488 Lines: 42 On 15/03/17 04:45, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the MODALIAS reported will always be of the form i2c:. > > But this could change in the future so the correct approach is to have an > OF device ID table if the devices are registered via OF. > > Signed-off-by: Javier Martinez Canillas Applied. > --- > > drivers/iio/accel/mma7660.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/iio/accel/mma7660.c b/drivers/iio/accel/mma7660.c > index 3a40774cca74..42fa57e41bdd 100644 > --- a/drivers/iio/accel/mma7660.c > +++ b/drivers/iio/accel/mma7660.c > @@ -253,6 +253,12 @@ static const struct i2c_device_id mma7660_i2c_id[] = { > }; > MODULE_DEVICE_TABLE(i2c, mma7660_i2c_id); > > +static const struct of_device_id mma7660_of_match[] = { > + { .compatible = "fsl,mma7660" }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, mma7660_of_match); > + > static const struct acpi_device_id mma7660_acpi_id[] = { > {"MMA7660", 0}, > {} > @@ -264,6 +270,7 @@ static struct i2c_driver mma7660_driver = { > .driver = { > .name = "mma7660", > .pm = MMA7660_PM_OPS, > + .of_match_table = mma7660_of_match, > .acpi_match_table = ACPI_PTR(mma7660_acpi_id), > }, > .probe = mma7660_probe, >