Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751289AbdCSK7z (ORCPT ); Sun, 19 Mar 2017 06:59:55 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:48542 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751300AbdCSK7w (ORCPT ); Sun, 19 Mar 2017 06:59:52 -0400 Subject: Re: [PATCH v2 17/17] iio: gyro: itg3200: Add OF device ID table To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <20170315044505.20660-1-javier@osg.samsung.com> <20170315044505.20660-18-javier@osg.samsung.com> Cc: linux-iio@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler From: Jonathan Cameron Message-ID: <4cefd496-9a87-f6da-58cd-c0310bd4e4eb@kernel.org> Date: Sun, 19 Mar 2017 10:59:49 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170315044505.20660-18-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1466 Lines: 44 On 15/03/17 04:45, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the MODALIAS reported will always be of the form i2c:. > > But this could change in the future so the correct approach is to have an > OF device ID table if the devices are registered via OF. > > Signed-off-by: Javier Martinez Canillas Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > > --- > > drivers/iio/gyro/itg3200_core.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/iio/gyro/itg3200_core.c b/drivers/iio/gyro/itg3200_core.c > index c102a6325bb0..cfa2db04a8ab 100644 > --- a/drivers/iio/gyro/itg3200_core.c > +++ b/drivers/iio/gyro/itg3200_core.c > @@ -377,9 +377,16 @@ static const struct i2c_device_id itg3200_id[] = { > }; > MODULE_DEVICE_TABLE(i2c, itg3200_id); > > +static const struct of_device_id itg3200_of_match[] = { > + { .compatible = "invensense,itg3200" }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, itg3200_of_match); > + > static struct i2c_driver itg3200_driver = { > .driver = { > .name = "itg3200", > + .of_match_table = itg3200_of_match, > .pm = &itg3200_pm_ops, > }, > .id_table = itg3200_id, >