Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752114AbdCSPuz (ORCPT ); Sun, 19 Mar 2017 11:50:55 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:53736 "EHLO hera.aquilenet.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751490AbdCSPux (ORCPT ); Sun, 19 Mar 2017 11:50:53 -0400 Date: Sun, 19 Mar 2017 16:50:49 +0100 From: Samuel Thibault To: Aleksey Makarov Cc: Steven Rostedt , Petr Mladek , Ming Lei , linux-serial@vger.kernel.org, Joe Perches , linux-kernel@vger.kernel.org Subject: Re: [PATCH] braille-console: Fix value returned by _braille_console_setup Message-ID: <20170319155049.ea7uau3gqkpnmemt@var.youpi.perso.aquilenet.fr> Mail-Followup-To: Samuel Thibault , Aleksey Makarov , Steven Rostedt , Petr Mladek , Ming Lei , linux-serial@vger.kernel.org, Joe Perches , linux-kernel@vger.kernel.org References: <20170319143726.p6motwasbc2lfdao@var.youpi.perso.aquilenet.fr> <0e1043b5-c585-5f4a-cde7-1afd60c0db56@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0e1043b5-c585-5f4a-cde7-1afd60c0db56@linaro.org> Organization: I am not organized User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1058 Lines: 25 Aleksey Makarov, on dim. 19 mars 2017 18:44:23 +0300, wrote: > On 03/19/2017 05:37 PM, Samuel Thibault wrote: > > commit bbeddf52adc1 ("printk: move braille console support into > > separate braille.[ch] files") introduced _braille_console_setup() > > to outline the braille initialization code. There was however some > > confusion over the value it was supposed to return. commit 2cfe6c4ac7ee > > ("printk: Fix return of braille_register_console()") tried to fix it > > but failed to. > > > > This fixes and documents the returned value according to the use > > in printk.c: non-zero return means a parsing error, and thus this > > console configuration should be ignored. > > Did you test the code on real braille hardware? Not on actual hardware, but I checked that the output on the serial port is what is expected. > I am asking because there could also be other problems with the code > that have not been run for 3 years since it was changed. The code which actually implements the braille protocol has not changed since it was tested. Samuel