Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261754AbTEYKlP (ORCPT ); Sun, 25 May 2003 06:41:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261759AbTEYKlP (ORCPT ); Sun, 25 May 2003 06:41:15 -0400 Received: from notes.hallinto.turkuamk.fi ([195.148.215.149]:28423 "EHLO notes.hallinto.turkuamk.fi") by vger.kernel.org with ESMTP id S261754AbTEYKlO (ORCPT ); Sun, 25 May 2003 06:41:14 -0400 Message-ID: <3ED0A248.10308@kolumbus.fi> Date: Sun, 25 May 2003 14:00:24 +0300 From: =?ISO-8859-1?Q?Mika_Penttil=E4?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.2) Gecko/20030208 Netscape/7.02 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Zwane Mwaikambo CC: Ingo Molnar , Linux Kernel , Manfred Spraul , William Lee Irwin III Subject: Re: [RFC][PATCH][2.5] Possible race in wait_task_zombie and finish_task_switch References: X-MIMETrack: Itemize by SMTP Server on marconi.hallinto.turkuamk.fi/TAMK(Release 5.0.8 |June 18, 2001) at 25.05.2003 13:55:31, Serialize by Router on notes.hallinto.turkuamk.fi/TAMK(Release 5.0.10 |March 22, 2002) at 25.05.2003 13:55:03, Serialize complete at 25.05.2003 13:55:03 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 872 Lines: 39 Zwane Mwaikambo wrote: >On Sun, 25 May 2003, Ingo Molnar wrote: > > > >>On Sun, 25 May 2003, Zwane Mwaikambo wrote: >> >> >> >>> if (prev->state & (TASK_DEAD | TASK_ZOMBIE)) >>> put_task_struct(prev); >>> >>> >>we initialize tsk->usage with 2 in fork() - are you sure the removal of >>the above code will not result in a memory leak? >> >> > >Isn't current the forked task? Also we initialise the forked task's state >to TASK_UNINTERRUPTIBLE. > > Zwane > > The put_task_struct() above is for dropping our own reference after we exit. The other reference gets dropped by who is waiting for us. --Mika - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/