Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261852AbTEYL0F (ORCPT ); Sun, 25 May 2003 07:26:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261869AbTEYL0F (ORCPT ); Sun, 25 May 2003 07:26:05 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:29056 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S261852AbTEYL0E (ORCPT ); Sun, 25 May 2003 07:26:04 -0400 Date: Sun, 25 May 2003 12:39:12 +0100 From: viro@parcelfarce.linux.theplanet.co.uk To: Mitch@0Bits.COM Cc: linux-kernel@vger.kernel.org Subject: Re: Linux 2.4.21-rc3, writing to /dev/console returns ESPIPE Message-ID: <20030525113912.GB6270@parcelfarce.linux.theplanet.co.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1159 Lines: 40 On Sun, May 25, 2003 at 12:22:14PM +0100, Mitch@0Bits.COM wrote: > The checkin on linux-2.4.21-rc3/drivers/char/tty_io.c > > + /* Can't seek (pwrite) on ttys. */ > + if (ppos != &file->f_pos) > + return -ESPIPE; > > should not be there in my opinion. s/not be/be not/ --- drivers/char/tty_io.c Sat May 17 11:14:02 2003 +++ /tmp/tty_io.c Sun May 25 07:37:37 2003 @@ -751,6 +751,10 @@ struct tty_struct * tty; struct inode *inode = file->f_dentry->d_inode; + /* Can't seek (pwrite) on ttys. */ + if (ppos != &file->f_pos) + return -ESPIPE; + /* * For now, we redirect writes from /dev/console as * well as /dev/tty0. @@ -775,10 +779,6 @@ return res; } } - - /* Can't seek (pwrite) on ttys. */ - if (ppos != &file->f_pos) - return -ESPIPE; tty = (struct tty_struct *)file->private_data; if (tty_paranoia_check(tty, inode->i_rdev, "tty_write")) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/