From: Piotr Sroka <piotrs@cadence.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
CC: linux-mmc <linux-mmc@vger.kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration
Thread-Topic: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration
Thread-Index: AQHSnxvf5I09T95jWUSh7TvyReX6WaGZSCwAgAQkWaA=
Date: Mon, 20 Mar 2017 08:47:44 +0000
Message-ID: <DM5PR07MB308222A445B7A39CBFE4896ADD3A0@DM5PR07MB3082.namprd07.prod.outlook.com>
References: <1489754302-10996-1-git-send-email-piotrs@cadence.com>
 <1489754503-16559-1-git-send-email-piotrs@cadence.com>
 <CAK7LNAQGOeZVqvc=6Agq2xN5B5cBMtaCAkS8-V6uBoO1ziSSuw@mail.gmail.com>
In-Reply-To: <CAK7LNAQGOeZVqvc=6Agq2xN5B5cBMtaCAkS8-V6uBoO1ziSSuw@mail.gmail.com>
Accept-Language: pl-PL, en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2017 08:47:44.4970
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3081
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v2K8pDMG029868
Content-Length: 931
Lines: 40


> -----Original Message-----
> From: Masahiro Yamada [mailto:yamada.masahiro@socionext.com]
> Sent: 17 March, 2017 6:24 PM
> Subject: Re: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration
> 
> 
> 
> > @@ -62,10 +66,33 @@
> >   */
> >  #define SDHCI_CDNS_MAX_TUNING_LOOP     40
> >
> > +static const struct of_device_id sdhci_cdns_match[];
> > +
> 
> You forgot to remove this.
> 
You are right. Thanks.
 
> 
> > @@ -227,6 +267,7 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
> >         struct sdhci_cdns_priv *priv;
> >         struct clk *clk;
> >         int ret;
> > +       struct device *dev = &pdev->dev;
> >
> >         clk = devm_clk_get(&pdev->dev, NULL);
> 
> 
> If you add "dev", please use it for devm_clk_get, too.
> 
I did on the first patch version but Ulf pointed that this is unrelated change and should be removed. 
Therefore I remove it. 

> 
> 
> --
> Best Regards
> Masahiro Yamada