Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753501AbdCTJGn (ORCPT ); Mon, 20 Mar 2017 05:06:43 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:58262 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753294AbdCTJFj (ORCPT ); Mon, 20 Mar 2017 05:05:39 -0400 Date: Mon, 20 Mar 2017 09:05:25 +0000 From: Russell King - ARM Linux To: Philippe De Muyter Cc: Steve Longerbeam , Steve Longerbeam , sakari.ailus@linux.intel.com, hverkuil@xs4all.nl, linux-media@vger.kernel.org, kernel@pengutronix.de, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de Subject: Re: [PATCH 4/4] media: imx-media-capture: add frame sizes/interval enumeration Message-ID: <20170320090524.GC21222@n2100.armlinux.org.uk> References: <20170319103801.GQ21222@n2100.armlinux.org.uk> <20170320085512.GA20923@frolo.macqel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170320085512.GA20923@frolo.macqel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2217 Lines: 61 On Mon, Mar 20, 2017 at 09:55:12AM +0100, Philippe De Muyter wrote: > Hi Russel, > > On Sun, Mar 19, 2017 at 10:49:08AM +0000, Russell King wrote: > > Add support for enumerating frame sizes and frame intervals from the > > first subdev via the V4L2 interfaces. > > > > Signed-off-by: Russell King > > --- > > drivers/staging/media/imx/imx-media-capture.c | 62 +++++++++++++++++++++++++++ > > 1 file changed, 62 insertions(+) > > > ... > > +static int capture_enum_frameintervals(struct file *file, void *fh, > > + struct v4l2_frmivalenum *fival) > > +{ > > + struct capture_priv *priv = video_drvdata(file); > > + const struct imx_media_pixfmt *cc; > > + struct v4l2_subdev_frame_interval_enum fie = { > > + .index = fival->index, > > + .pad = priv->src_sd_pad, > > + .width = fival->width, > > + .height = fival->height, > > + .which = V4L2_SUBDEV_FORMAT_ACTIVE, > > + }; > > + int ret; > > + > > + cc = imx_media_find_format(fival->pixel_format, CS_SEL_ANY, true); > > + if (!cc) > > + return -EINVAL; > > + > > + fie.code = cc->codes[0]; > > + > > + ret = v4l2_subdev_call(priv->src_sd, pad, enum_frame_interval, NULL, &fie); > > + if (ret) > > + return ret; > > + > > + fival->type = V4L2_FRMIVAL_TYPE_DISCRETE; > > + fival->discrete = fie.interval; > > For some parallel sensors (mine is a E2V ev76c560) "any" frame interval is possible, > and hence type should be V4L2_FRMIVAL_TYPE_CONTINUOUS. For my sensor, any frame interval is also possible, but that isn't the point here. /dev/video* only talks to the CSI source pad, not it's sink pad. The sink pad gets configured with the sensor frame rate via the media controller API. /dev/video* itself has no control over the sensor frame rate. The media controller stuff completely changes the way the established /dev/video* functionality works - the ability to select arbitary frame sizes and frame rates supported by the ultimate sensor is gone. All that needs to be setup through the media controller pipeline, one subdev at a time. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.