Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753997AbdCTJyQ (ORCPT ); Mon, 20 Mar 2017 05:54:16 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:7515 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753786AbdCTJyK (ORCPT ); Mon, 20 Mar 2017 05:54:10 -0400 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 20 Mar 2017 02:47:47 -0700 Subject: Re: [PATCH] soc/tegra: fix link errors with PMC disabled To: Arnd Bergmann , Thierry Reding References: <20170320091405.1041129-1-arnd@arndb.de> CC: Laxman Dewangan , Mathieu Poirier , , From: Jon Hunter Message-ID: Date: Mon, 20 Mar 2017 09:47:39 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170320091405.1041129-1-arnd@arndb.de> X-Originating-IP: [10.26.11.169] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1301 Lines: 33 Hi Arnd, On 20/03/17 09:13, Arnd Bergmann wrote: > With the new Tegra186 PMC driver merged, anything that relies on the previous > PMC driver fails to link when that is disabled: > > arch/arm/mach-tegra/pm.o: In function `tegra_pm_set': > pm.c:(.text.tegra_pm_set+0x3c): undefined reference to `tegra_pmc_enter_suspend_mode' > arch/arm/mach-tegra/pm.o: In function `tegra_suspend_enter': > pm.c:(.text.tegra_suspend_enter+0x4): undefined reference to `tegra_pmc_get_suspend_mode' > arch/arm/mach-tegra/pm.o: In function `tegra_init_suspend': > pm.c:(.init.text+0x1c): undefined reference to `tegra_pmc_get_suspend_mode' > pm.c:(.init.text+0x74): undefined reference to `tegra_pmc_set_suspend_mode' > > ERROR: tegra_powergate_sequence_power_up [drivers/ata/ahci_tegra.ko] undefined! > ERROR: tegra_powergate_power_off [drivers/ata/ahci_tegra.ko] undefined! > > Making the definition depend on the presence of the driver makes it build > again, though that might not be the correct fix. > > Fixes: 854014236290 ("soc/tegra: Implement Tegra186 PMC support") > Signed-off-by: Arnd Bergmann A fix was also submitted by Krzysztof [0]. Thierry, what's your preference? Maybe Arnd's approach is better. Jon [0] http://marc.info/?l=linux-arm-kernel&m=148926404419311&w=2 -- nvpublic