Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753765AbdCTKIh (ORCPT ); Mon, 20 Mar 2017 06:08:37 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:36749 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753694AbdCTKHg (ORCPT ); Mon, 20 Mar 2017 06:07:36 -0400 Date: Mon, 20 Mar 2017 10:59:30 +0100 From: Daniel Vetter To: Arnd Bergmann Cc: Rob Clark , David Airlie , Archit Taneja , Daniel Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/msm: add stubs for msm_{perf,rd}_debugfs_cleanup Message-ID: <20170320095930.pi4dwdwd4oxv4nxe@phenom.ffwll.local> Mail-Followup-To: Arnd Bergmann , Rob Clark , David Airlie , Archit Taneja , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20170320093936.1255573-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170320093936.1255573-1-arnd@arndb.de> X-Operating-System: Linux phenom 4.8.0-1-amd64 User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1728 Lines: 41 On Mon, Mar 20, 2017 at 10:39:25AM +0100, Arnd Bergmann wrote: > We now call those two functions even when they are not defined > or declared anywhere because DEBUG_FS is disabled: > > drivers/gpu/drm/msm/msm_drv.c: In function 'msm_drm_uninit': > drivers/gpu/drm/msm/msm_drv.c:244:2: error: implicit declaration of function 'msm_perf_debugfs_cleanup';did you mean 'msm_framebuffer_cleanup'? [-Werror=implicit-function-declaration] > drivers/gpu/drm/msm/msm_drv.c:245:2: error: implicit declaration of function 'msm_rd_debugfs_cleanup';did you mean 'msm_framebuffer_cleanup'? [-Werror=implicit-function-declaration] > > This adds empty stub implementations for that case. > > Fixes: 85eac4700ede ("drm/msm: Remove msm_debugfs_cleanup()") > Signed-off-by: Arnd Bergmann Pushed to drm-misc-next to patch up the .config fail. Thanks, Daniel > --- > drivers/gpu/drm/msm/msm_drv.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h > index b51fb0d70f43..b885c3d5ae4d 100644 > --- a/drivers/gpu/drm/msm/msm_drv.h > +++ b/drivers/gpu/drm/msm/msm_drv.h > @@ -311,6 +311,8 @@ void msm_perf_debugfs_cleanup(struct msm_drm_private *priv); > #else > static inline int msm_debugfs_late_init(struct drm_device *dev) { return 0; } > static inline void msm_rd_dump_submit(struct msm_gem_submit *submit) {} > +static inline void msm_rd_debugfs_cleanup(struct msm_drm_private *priv) {} > +static inline void msm_perf_debugfs_cleanup(struct msm_drm_private *priv) {} > #endif > > struct clk *msm_clk_get(struct platform_device *pdev, const char *name); > -- > 2.9.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch